public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	linux-can@vger.kernel.org,
	Vincent Mailhol <vincent.mailhol@gmail.com>,
	Oliver Neukum <oneukum@suse.com>,
	linux-kernel@vger.kernel.org,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Mon, 27 Jun 2022 19:01:26 +0200	[thread overview]
Message-ID: <20220627190126.4eb57a2b.max@enpas.org> (raw)
In-Reply-To: <20220627150557.qluqtejrddj5nfif@pengutronix.de>

On Mon, 27 Jun 2022 17:05:57 +0200
Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> On 18.06.2022 21:50:31, Max Staudt wrote:
> > This is the can327 driver. It does a surprisingly good job at
> > turning ELM327 based OBD-II interfaces into cheap CAN interfaces
> > for simple homebrew projects.
> > 
> > Please see the included documentation for details and limitations:
> > Documentation/networking/device_drivers/can/can327.rst
> > 
> > Cc: linux-can <linux-can@vger.kernel.org>
> > Signed-off-by: Max Staudt <max@enpas.org>
> > Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>  
> 
> Added with some minor coding style improvements (line breaks and
> whitespace changes) to make checkpatch and clang-format happier to
> can-next/master!

Wonderful, thank you!

(+CC: Greg, Oliver Hartkopp)


This quite fittingly marks the end of an era for me, so I would like to
thank everyone involved, more or less in order of appearance:

Oliver Hartkopp    for slcan (the inspiration) and related feedback.
Oliver Neukum      for the first reviews, before this went public.
Marc Kleine-Budde  for upstream guidance.
Greg Kroah-Hartman for TTY and style support.
Vincent Mailhol    for intensive reviews up until the end.

...and of course thanks to the numerous people I've been in touch with
via GitHub and otherwise. Bug reports, testing, or simply thanks and
encouragement - they have all helped.


Some stats for those interested: It has been a solid 8 years since the
idea for this driver was born in 2014, with occasional on and off work
on it since. The oldest code is from 2015, running in userspace and
injecting packets via vcan. It became a kernel module in 2016, with
link settings via "ip link". The first public version was released in
2018. It then gained in popularity, making upstreaming... inevitable ;)


Thank you all!


Max

  reply	other threads:[~2022-06-27 17:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18 19:50 [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-06-18 22:02 ` kernel test robot
2022-06-19  8:08   ` Marc Kleine-Budde
2022-06-27 15:05 ` Marc Kleine-Budde
2022-06-27 17:01   ` Max Staudt [this message]
2022-07-05  9:43     ` Geert Uytterhoeven
2022-07-05  9:49       ` Marc Kleine-Budde
2022-07-05  9:56         ` Max Staudt
2022-07-05 10:16           ` Geert Uytterhoeven
2022-07-05 10:39             ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220627190126.4eb57a2b.max@enpas.org \
    --to=max@enpas.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=oneukum@suse.com \
    --cc=socketcan@hartkopp.net \
    --cc=vincent.mailhol@gmail.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox