From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4983CCCA47E for ; Mon, 27 Jun 2022 17:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239754AbiF0RCS (ORCPT ); Mon, 27 Jun 2022 13:02:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235496AbiF0RCN (ORCPT ); Mon, 27 Jun 2022 13:02:13 -0400 Received: from mail.enpas.org (zhong.enpas.org [46.38.239.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 82F6F12090; Mon, 27 Jun 2022 10:02:11 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id 814CFFF9BF; Mon, 27 Jun 2022 17:02:09 +0000 (UTC) Date: Mon, 27 Jun 2022 19:01:26 +0200 From: Max Staudt To: Marc Kleine-Budde Cc: Wolfgang Grandegger , linux-can@vger.kernel.org, Vincent Mailhol , Oliver Neukum , linux-kernel@vger.kernel.org, Vincent Mailhol , Greg Kroah-Hartman , Oliver Hartkopp Subject: Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters Message-ID: <20220627190126.4eb57a2b.max@enpas.org> In-Reply-To: <20220627150557.qluqtejrddj5nfif@pengutronix.de> References: <20220618195031.10975-1-max@enpas.org> <20220627150557.qluqtejrddj5nfif@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jun 2022 17:05:57 +0200 Marc Kleine-Budde wrote: > On 18.06.2022 21:50:31, Max Staudt wrote: > > This is the can327 driver. It does a surprisingly good job at > > turning ELM327 based OBD-II interfaces into cheap CAN interfaces > > for simple homebrew projects. > > > > Please see the included documentation for details and limitations: > > Documentation/networking/device_drivers/can/can327.rst > > > > Cc: linux-can > > Signed-off-by: Max Staudt > > Reviewed-by: Vincent Mailhol > > Added with some minor coding style improvements (line breaks and > whitespace changes) to make checkpatch and clang-format happier to > can-next/master! Wonderful, thank you! (+CC: Greg, Oliver Hartkopp) This quite fittingly marks the end of an era for me, so I would like to thank everyone involved, more or less in order of appearance: Oliver Hartkopp for slcan (the inspiration) and related feedback. Oliver Neukum for the first reviews, before this went public. Marc Kleine-Budde for upstream guidance. Greg Kroah-Hartman for TTY and style support. Vincent Mailhol for intensive reviews up until the end. ...and of course thanks to the numerous people I've been in touch with via GitHub and otherwise. Bug reports, testing, or simply thanks and encouragement - they have all helped. Some stats for those interested: It has been a solid 8 years since the idea for this driver was born in 2014, with occasional on and off work on it since. The oldest code is from 2015, running in userspace and injecting packets via vcan. It became a kernel module in 2016, with link settings via "ip link". The first public version was released in 2018. It then gained in popularity, making upstreaming... inevitable ;) Thank you all! Max