From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9268FC433EF for ; Tue, 28 Jun 2022 02:23:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243993AbiF1CXJ (ORCPT ); Mon, 27 Jun 2022 22:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243745AbiF1CVc (ORCPT ); Mon, 27 Jun 2022 22:21:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 278B024BE1; Mon, 27 Jun 2022 19:21:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE5A8B818E4; Tue, 28 Jun 2022 02:21:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAD84C36AE5; Tue, 28 Jun 2022 02:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656382882; bh=Gx50wDzQU5N6gDpRHLl9R6YCgbOEWXoj1h8NlNVhINM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q9QsEiu9K9tLVz3w3UFKinE2Dh81NMrYgJirlMFCtS/RrEXHWGTqnw3e6MGSVjW24 V0+Vf774T8rdTHuM8hYi3n6YZM41jcw9TVuxH+DcAQc7YVjTSZnlK9ibQ3DLHtRNZV XmZ3lc4XjRkd2xdLlQM8r06OCGXkpD90zUOR5w4HRDQJoYS3keFdw7hpI7K5pivAwd jM5Chi+rL9+NdhgYJAE/xUmP3wLHOoZOTmCYJjcCKmDSSo8KusR6sc28DQcdcO1dqs 4PeWtJ9khHzCCqyWhizXmYXWrItQPYtc4laNweTzoR3LIOv/lkB3R3nZRz7PDHmAlV Yad2tUkSA6v6A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ding Xiang , Shuah Khan , Sasha Levin , shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 11/41] selftests: vm: Fix resource leak when return error Date: Mon, 27 Jun 2022 22:20:30 -0400 Message-Id: <20220628022100.595243-11-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022100.595243-1-sashal@kernel.org> References: <20220628022100.595243-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ding Xiang [ Upstream commit 3084a4ec7f9bb1ec90036cfd01b1abadc5dd4fb2 ] When return on an error path, file handle need to be closed to prevent resource leak Signed-off-by: Ding Xiang Reviewed-by: Shuah Khan Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/vm/ksm_tests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c index b61dcdb44c5b..b31f7a17d92a 100644 --- a/tools/testing/selftests/vm/ksm_tests.c +++ b/tools/testing/selftests/vm/ksm_tests.c @@ -48,6 +48,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val) } if (fprintf(f, "%lu", val) < 0) { perror("fprintf"); + fclose(f); return 1; } fclose(f); @@ -66,6 +67,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val) } if (fscanf(f, "%lu", val) != 1) { perror("fscanf"); + fclose(f); return 1; } fclose(f); -- 2.35.1