From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 532E9CCA47B for ; Tue, 28 Jun 2022 02:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244902AbiF1Ca2 (ORCPT ); Mon, 27 Jun 2022 22:30:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244307AbiF1C0j (ORCPT ); Mon, 27 Jun 2022 22:26:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D47FA24BF0; Mon, 27 Jun 2022 19:24:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6FE8E61799; Tue, 28 Jun 2022 02:24:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71289C341D4; Tue, 28 Jun 2022 02:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383066; bh=/F6BUw+Sh4FJw5Go2ezyISs3lQbyhPGnRIo/Of42iuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=muDZUbTgM+Enro6lgD2NLGiTcogQB5/v1IASFztCaLukQa1YkwS5UhvUm+h0vmTv6 UQ3jyUIc7l/lXk2Wa2zFMlVzkLAgu41kqfM6b3BviHjWnS+eh+/914HJ0SGqNd4DoZ Gzhx3ammTg89I+p+1VvNgJcGYO42Cee/E4eObV2hg0LLosiIAzTT1Q6E2+lQ3CV5ds i0urLMoLgpOlh4/2v0Bw3/LTU5Bb7V8Vwg4LT/TdWkPWuW96J6ZPesopPuVZkuwt08 NIaMdeLUROiuM3RXx9Aeds/M5NkHgDrBqbtjOh5YBhmqL6hJuorsOB2gzPbaz043i9 LaHpYSsm6/A9g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pierre-Louis Bossart , Bard Liao , Kai Vehmanen , Ranjani Sridharan , Takashi Iwai , Sasha Levin , perex@perex.cz, tiwai@suse.com, jiasheng@iscas.ac.cn, nizhen@uniontech.com, gushengxian@yulong.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.4 06/27] ALSA: x86: intel_hdmi_audio: enable pm_runtime and set autosuspend delay Date: Mon, 27 Jun 2022 22:23:52 -0400 Message-Id: <20220628022413.596341-6-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022413.596341-1-sashal@kernel.org> References: <20220628022413.596341-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre-Louis Bossart [ Upstream commit e87c65aeb46ca4f5b7dc08531200bcb8a426c62e ] The existing code uses pm_runtime_get_sync/put_autosuspend, but pm_runtime was not explicitly enabled. The autosuspend delay was not set either, the value is set to 5s since HDMI is rather painful to resume. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani Sridharan Link: https://lore.kernel.org/r/20220616222910.136854-2-pierre-louis.bossart@linux.intel.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/x86/intel_hdmi_audio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c index a314f13e3292..f16e936559c3 100644 --- a/sound/x86/intel_hdmi_audio.c +++ b/sound/x86/intel_hdmi_audio.c @@ -33,6 +33,8 @@ #include #include "intel_hdmi_audio.h" +#define INTEL_HDMI_AUDIO_SUSPEND_DELAY_MS 5000 + #define for_each_pipe(card_ctx, pipe) \ for ((pipe) = 0; (pipe) < (card_ctx)->num_pipes; (pipe)++) #define for_each_port(card_ctx, port) \ @@ -1843,8 +1845,11 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) pdata->notify_audio_lpe = notify_audio_lpe; spin_unlock_irq(&pdata->lpe_audio_slock); + pm_runtime_set_autosuspend_delay(&pdev->dev, INTEL_HDMI_AUDIO_SUSPEND_DELAY_MS); pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_enable(&pdev->dev); pm_runtime_mark_last_busy(&pdev->dev); + pm_runtime_idle(&pdev->dev); dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__); for_each_port(card_ctx, port) { -- 2.35.1