From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0822C43334 for ; Tue, 28 Jun 2022 04:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbiF1Et7 (ORCPT ); Tue, 28 Jun 2022 00:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243911AbiF1Etu (ORCPT ); Tue, 28 Jun 2022 00:49:50 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A78F812A82 for ; Mon, 27 Jun 2022 21:49:49 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o63AU-0006qc-Le; Tue, 28 Jun 2022 06:49:42 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1o63AU-0003gs-CE; Tue, 28 Jun 2022 06:49:42 +0200 Date: Tue, 28 Jun 2022 06:49:42 +0200 From: Oleksij Rempel To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Anton Lundin , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Lukas Wunner Subject: Re: [PATCH net v1 2/2] net: usb: asix: do not force pause frames support Message-ID: <20220628044942.GC13092@pengutronix.de> References: <20220624075139.3139300-1-o.rempel@pengutronix.de> <20220624075139.3139300-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220624075139.3139300-2-o.rempel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2022 at 09:51:39AM +0200, Oleksij Rempel wrote: > We should respect link partner capabilities and not force flow control > support on every link. Even more, in current state the MAC driver do not > advertises pause support so we should not keep flow control enabled at > all. > > Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") > Reported-by: Anton Lundin > Signed-off-by: Oleksij Rempel In different mail thread Anton reported as tested. Tested-by: Anton Lundin > --- > drivers/net/usb/asix.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h > index 2c81236c6c7c..45d3cc5cc355 100644 > --- a/drivers/net/usb/asix.h > +++ b/drivers/net/usb/asix.h > @@ -126,8 +126,7 @@ > AX_MEDIUM_RE) > > #define AX88772_MEDIUM_DEFAULT \ > - (AX_MEDIUM_FD | AX_MEDIUM_RFC | \ > - AX_MEDIUM_TFC | AX_MEDIUM_PS | \ > + (AX_MEDIUM_FD | AX_MEDIUM_PS | \ > AX_MEDIUM_AC | AX_MEDIUM_RE) > > /* AX88772 & AX88178 RX_CTL values */ > -- > 2.30.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |