Re: [PATCH RESEND v5 12/18] PCI: dwc: Re-use local pointer to the resource data

Manivannan Sadhasivam
2022-06-28T06:40:04Z

On Fri, Jun 24, 2022 at 05:34:22PM +0300, Serge Semin wrote:
> The dw_pcie_host_init() method has two instances of the resource structure
> pointers used in non-related places of the method. It's pointless to have
> two different local storages for them since the corresponding code is
> small and having resource specific names doesn't make it more readable.
> Let's convert these parts of the function to using just a common pointer
> to the resource structure instance. That shall make the code a bit nicer
> looking.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> Reviewed-by: Rob Herring <robh@kernel.org>
>
> ---
>
> Changelog v4:
> - This is a new patch created on the v4 lap of the series.
> ---
> .../pci/controller/dwc/pcie-designware-host.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 54257874c154..2f13eec4812d 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -293,17 +293,17 @@ int dw_pcie_host_init(struct pcie_port *pp)
> struct platform_device *pdev = to_platform_device(dev);
> struct resource_entry *win;
> struct pci_host_bridge *bridge;
> - struct resource *cfg_res;
> + struct resource *res;
> int ret;
>
> raw_spin_lock_init(&pp->lock);
>
> - cfg_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config");
> - if (cfg_res) {
> - pp->cfg0_size = resource_size(cfg_res);
> - pp->cfg0_base = cfg_res->start;
> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config");
> + if (res) {
> + pp->cfg0_size = resource_size(res);
> + pp->cfg0_base = res->start;
>
> - pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, cfg_res);
> + pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, res);
> if (IS_ERR(pp->va_cfg0_base))
> return PTR_ERR(pp->va_cfg0_base);
> } else {
> @@ -312,8 +312,8 @@ int dw_pcie_host_init(struct pcie_port *pp)
> }
>
> if (!pci->dbi_base) {
> - struct resource *dbi_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi");
> - pci->dbi_base = devm_pci_remap_cfg_resource(dev, dbi_res);
> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi");
> + pci->dbi_base = devm_pci_remap_cfg_resource(dev, res);
> if (IS_ERR(pci->dbi_base))
> return PTR_ERR(pci->dbi_base);
> }
> --
> 2.35.1
>

--
மணிவண்ணன் சதாசிவம்