Re: [PATCH RESEND v5 00/18] PCI: dwc: Various fixes and cleanups

Serge Semin
2022-07-11T18:40:29Z

Hi Bjorn.

On Wed, Jun 29, 2022 at 04:38:36AM +0300, Serge Semin wrote:
> On Tue, Jun 28, 2022 at 06:35:27PM -0500, Bjorn Helgaas wrote:
> > On Fri, Jun 24, 2022 at 05:34:10PM +0300, Serge Semin wrote:
> > > This patchset is a first one in the series created in the framework of
> > > my Baikal-T1 PCIe/eDMA-related work:
> > >
> > > [1: In-progress v5] PCI: dwc: Various fixes and cleanups
> > > Link: ---you are looking at it---
> > > [2: In-progress v3] PCI: dwc: Add hw version and dma-ranges support
> > > Link: https://lore.kernel.org/linux-pci/20220610084444.14549-1-Sergey.Semin@baikalelectronics.ru/
> > > [3: In-progress v3] PCI: dwc: Add generic resources and Baikal-T1 support
> > > Link: https://lore.kernel.org/linux-pci/20220610085706.15741-1-Sergey.Semin@baikalelectronics.ru/
> > > [4: In-progress v3] dmaengine: dw-edma: Add RP/EP local DMA support
> > > Link: https://lore.kernel.org/linux-pci/20220610091459.17612-1-Sergey.Semin@baikalelectronics.ru/
> > >
> > > Note it is very recommended to merge the patchsets in the same order as
> > > they are placed in the list above in order to prevent possible merge
> > > conflicts. Nothing prevents them from being reviewed synchronously though.
> > > Any tests are very welcome!
> > >
> > > [...]
> > >
> > > Link: https://lore.kernel.org/linux-pci/20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru/
> > > Changelog v5:
> > > - Just resend the series.
> > > - Rebase onto v5.19-rcX.
> > >
> > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > > Cc: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
> > > Cc: Jingoo Han <jingoohan1@gmail.com>
> > > Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> > > Cc: "Krzysztof Wilczyński" <kw@linux.com>
> > > Cc: Frank Li <Frank.Li@nxp.com>
> > > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > Cc: linux-pci@vger.kernel.org
> > > Cc: linux-kernel@vger.kernel.org
> >
>

> > I applied these to pci/ctrl/dwc-fixes for now. We'll have some tweaks
> > (to merge with previous dwc changes, if nothing else), but I pushed
> > this interim version
>
> I've got three more DW PCIe+eDMA based patchsets to review and merge in.
> As I noted in the cover letter and graphically represented here:
> Link: https://lore.kernel.org/linux-pci/20220616152048.gcqacgs2ed66vsl4@mobilestation/
> the last series depends on the previous changes and the changes
> introduced by Frank Li. The Frank' work has been merged in into the
> branch 'pci/edma' of your repo. Could you please move my patchset(s)
> there too in order to avoid merge conflicts in future?

Are you back from vacation yet? If so please consider the request
above.

-Sergey

>
> > since I'll be on vacation for a week or so.
> >
>
> * Sigh... I have a feeling one more merge window will pass with
> my patchsets hanging out in limbo.
>
> > Looks like some nice fixes and cleanups, thank you!
>
> Thanks.
>
> -Sergey
>
> >
> > > Serge Semin (18):
> > > PCI: dwc: Stop link in the host init error and de-initialization
> > > PCI: dwc: Add unroll iATU space support to the regions disable method
> > > PCI: dwc: Disable outbound windows for controllers with iATU
> > > PCI: dwc: Set INCREASE_REGION_SIZE flag based on limit address
> > > PCI: dwc: Deallocate EPC memory on EP init error
> > > PCI: dwc: Enable CDM-check independently from the num_lanes value
> > > PCI: dwc: Add braces to the multi-line if-else statements
> > > PCI: dwc: Add trailing new-line literals to the log messages
> > > PCI: dwc: Discard IP-core version checking on unrolled iATU detection
> > > PCI: dwc: Convert Link-up status method to using dw_pcie_readl_dbi()
> > > PCI: dwc: Organize local variables usage
> > > PCI: dwc: Re-use local pointer to the resource data
> > > PCI: dwc: Add start_link/stop_link inliners
> > > PCI: dwc: Move io_cfg_atu_shared to the Root Port descriptor
> > > PCI: dwc: Add dw_ prefix to the pcie_port structure name
> > > PCI: dwc-plat: Simplify the probe method return value handling
> > > PCI: dwc-plat: Discard unused regmap pointer
> > > PCI: dwc-plat: Drop dw_plat_pcie_of_match forward declaration
> > >
> > > drivers/pci/controller/dwc/pci-dra7xx.c | 12 +--
> > > drivers/pci/controller/dwc/pci-exynos.c | 6 +-
> > > drivers/pci/controller/dwc/pci-imx6.c | 6 +-
> > > drivers/pci/controller/dwc/pci-keystone.c | 20 ++--
> > > .../pci/controller/dwc/pci-layerscape-ep.c | 12 ---
> > > drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
> > > drivers/pci/controller/dwc/pci-meson.c | 2 +-
> > > drivers/pci/controller/dwc/pcie-al.c | 6 +-
> > > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +-
> > > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +-
> > > .../pci/controller/dwc/pcie-designware-ep.c | 30 ++++--
> > > .../pci/controller/dwc/pcie-designware-host.c | 102 ++++++++++--------
> > > .../pci/controller/dwc/pcie-designware-plat.c | 25 ++---
> > > drivers/pci/controller/dwc/pcie-designware.c | 72 +++++++------
> > > drivers/pci/controller/dwc/pcie-designware.h | 46 +++++---
> > > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +-
> > > drivers/pci/controller/dwc/pcie-fu740.c | 2 +-
> > > drivers/pci/controller/dwc/pcie-histb.c | 10 +-
> > > drivers/pci/controller/dwc/pcie-intel-gw.c | 6 +-
> > > drivers/pci/controller/dwc/pcie-keembay.c | 4 +-
> > > drivers/pci/controller/dwc/pcie-kirin.c | 2 +-
> > > drivers/pci/controller/dwc/pcie-qcom.c | 4 +-
> > > drivers/pci/controller/dwc/pcie-spear13xx.c | 6 +-
> > > drivers/pci/controller/dwc/pcie-tegra194.c | 22 ++--
> > > drivers/pci/controller/dwc/pcie-uniphier.c | 10 +-
> > > drivers/pci/controller/dwc/pcie-visconti.c | 6 +-
> > > 26 files changed, 224 insertions(+), 201 deletions(-)
> > >
> > > --
> > > 2.35.1
> > >