From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED27C43334 for ; Tue, 28 Jun 2022 08:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243513AbiF1IAV (ORCPT ); Tue, 28 Jun 2022 04:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241810AbiF1IAT (ORCPT ); Tue, 28 Jun 2022 04:00:19 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D648B12777 for ; Tue, 28 Jun 2022 01:00:17 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o668n-0004zr-Hn; Tue, 28 Jun 2022 10:00:09 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1o668m-00062t-Ud; Tue, 28 Jun 2022 10:00:08 +0200 Date: Tue, 28 Jun 2022 10:00:08 +0200 From: Oleksij Rempel To: Lucas Stach Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Anton Lundin , Lukas Wunner , linux-kernel@vger.kernel.org, kernel@pengutronix.de, netdev@vger.kernel.org Subject: Re: [PATCH net v1 1/2] net: asix: fix "can't send until first packet is send" issue Message-ID: <20220628080008.GF13092@pengutronix.de> References: <20220624075139.3139300-1-o.rempel@pengutronix.de> <20220628044913.GB13092@pengutronix.de> <897594cde5f294f9d5e96917bce1ac751338d0aa.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <897594cde5f294f9d5e96917bce1ac751338d0aa.camel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 09:50:42AM +0200, Lucas Stach wrote: > Hi Oleksij, > > subject of this patch looks strange. It should probably read "can't > receive until first packet is sent". rigth. But it is already taken. > Regards, > Lucas > > Am Dienstag, dem 28.06.2022 um 06:49 +0200 schrieb Oleksij Rempel: > > On Fri, Jun 24, 2022 at 09:51:38AM +0200, Oleksij Rempel wrote: > > > If cable is attached after probe sequence, the usbnet framework would > > > not automatically start processing RX packets except at least one > > > packet was transmitted. > > > > > > On systems with any kind of address auto configuration this issue was > > > not detected, because some packets are send immediately after link state > > > is changed to "running". > > > > > > With this patch we will notify usbnet about link status change provided by the > > > PHYlib. > > > > > > Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") > > > Reported-by: Anton Lundin > > > Signed-off-by: Oleksij Rempel > > > > In different mail thread Anton reported as tested. > > Tested-by: Anton Lundin > > > > > --- > > > drivers/net/usb/asix_common.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c > > > index 632fa6c1d5e3..b4a1b7abcfc9 100644 > > > --- a/drivers/net/usb/asix_common.c > > > +++ b/drivers/net/usb/asix_common.c > > > @@ -431,6 +431,7 @@ void asix_adjust_link(struct net_device *netdev) > > > > > > asix_write_medium_mode(dev, mode, 0); > > > phy_print_status(phydev); > > > + usbnet_link_change(dev, phydev->link, 0); > > > } > > > > > > int asix_write_gpio(struct usbnet *dev, u16 value, int sleep, int in_pm) > > > -- > > > 2.30.2 > > > > > > > > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |