* [PATCH -next] net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get()
@ 2022-06-29 9:24 Yang Yingliang
2022-06-29 9:49 ` Clément Léger
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-06-29 9:24 UTC (permalink / raw)
To: linux-kernel, netdev, linux-renesas-soc
Cc: clement.leger, olteanv, f.fainelli, davem
of_parse_phandle() will increase the refcount of 'pcs_node', so add
of_node_put() before return from a5psw_pcs_get().
Fixes: 888cdb892b61 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/dsa/rzn1_a5psw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
index 3e910da98ae2..301171ee1061 100644
--- a/drivers/net/dsa/rzn1_a5psw.c
+++ b/drivers/net/dsa/rzn1_a5psw.c
@@ -923,6 +923,7 @@ static int a5psw_pcs_get(struct a5psw *a5psw)
return 0;
free_pcs:
+ of_node_put(pcs_node);
of_node_put(port);
of_node_put(ports);
a5psw_pcs_free(a5psw);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get()
2022-06-29 9:24 [PATCH -next] net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get() Yang Yingliang
@ 2022-06-29 9:49 ` Clément Léger
0 siblings, 0 replies; 2+ messages in thread
From: Clément Léger @ 2022-06-29 9:49 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, netdev, linux-renesas-soc, olteanv, f.fainelli,
davem
Le Wed, 29 Jun 2022 17:24:35 +0800,
Yang Yingliang <yangyingliang@huawei.com> a écrit :
> of_parse_phandle() will increase the refcount of 'pcs_node', so add
> of_node_put() before return from a5psw_pcs_get().
>
> Fixes: 888cdb892b61 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/dsa/rzn1_a5psw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
> index 3e910da98ae2..301171ee1061 100644
> --- a/drivers/net/dsa/rzn1_a5psw.c
> +++ b/drivers/net/dsa/rzn1_a5psw.c
> @@ -923,6 +923,7 @@ static int a5psw_pcs_get(struct a5psw *a5psw)
> return 0;
>
> free_pcs:
> + of_node_put(pcs_node);
of_node_put(pcs_node) should probably also be called after
miic_create(a5psw->dev, pcs_node); since it is not needed anymore.
Clément
> of_node_put(port);
> of_node_put(ports);
> a5psw_pcs_free(a5psw);
--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-29 9:24 [PATCH -next] net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get() Yang Yingliang
2022-06-29 9:49 ` Clément Léger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox