Re: [PATCH] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables

Krzysztof Kozlowski
2022-06-30T07:01:16Z

On 29/06/2022 20:53, Tom Rix wrote:
> sparse reports
> sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static?
> sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static?
>
> Both gpiod_speaker_power and rx1950_audio are only used in rx1950_uda1380.c,
> so their storage class specifiers should be static.
>
> Fixes: 83d74e354200 ("ASoC: samsung: rx1950: turn into platform driver")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof