From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92612C43334 for ; Wed, 29 Jun 2022 23:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231319AbiF2XAI (ORCPT ); Wed, 29 Jun 2022 19:00:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbiF2W7p (ORCPT ); Wed, 29 Jun 2022 18:59:45 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D9514091D for ; Wed, 29 Jun 2022 15:58:55 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id u6-20020a17090a1d4600b001ec8200fe70so403575pju.1 for ; Wed, 29 Jun 2022 15:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=bg9ioyZvi3pggVC6pmrxVE3PJI7RkTo447asQNSDMCo=; b=XOgKAp54Uomy/MmM0rVyzKaifQUFQpoD1t30MT8UmSk4KOHvi9VYQBtLOKeJ3qoCT6 wKGwjYZo3g/dGbJKaFBT0jIkbA+P95nNjL2xa4BsbkANz7tvu+bPqV5M8zspj86R+6Pi MDg5CsnBjFcma+9cvcJBzeQsANG9udxS/lKWSY08OdTFEmDpkxrpjs5t3nG/ldOT7AGM 7hzpNc6DEU9m08IurlitD8wgQ25ff1MNozL2+BK/fRrn3NUTBMXMlKIb3EbzbNi+qb06 MXSZ/NUMCzRQbU0iubhU+b7vDdg89J0/lN9T+uF2q0aPOpHKL4BzM0lhzoXcqTuaIp3O yiJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=bg9ioyZvi3pggVC6pmrxVE3PJI7RkTo447asQNSDMCo=; b=TwyH6dTAzjoo35rZVCGmWaofkKuJhtAT0WtjnF4fmhERRkEuWSjhbKYwnHSWZCEitz XUfcPV7DaQXsYbP9kaEDjk2lzN9JCaFFSS0OIoznGwUFQz8ZOU8lWCiJ7B9chOwefyiI e8k4z58c1xEXE/bNF7ZKsaXDIs9rxGG5+55+9K5ivb6rWzPeYi5x+eibiM2F98GhqH6f /iQ23sNuYpQFYbe2zoGjTK1y9giyc/EHbdfv0a3AbtJkhEv8j/xD3ye4oB9PATPNtZlT 7ClxiYzHif2jqKjZHCig+fhUIgTFV0+KZW2WkPtvGkPNhoM769RDCT7uG2FwH+YeUKoG oQYQ== X-Gm-Message-State: AJIora+peUoywLOsXFuG3ukMIqGaULGxHfpAS4wfl/gxYXZzPTXI3GVJ LdydCt6rFfKA4d92EcsjNxFc3gjLlE9LfvPidY0= X-Google-Smtp-Source: AGRyM1uFrWDjwr0dMIMwLT0wv42PT1NVpnfJp0c1gw3lcilw2C0s09prA0+AV6JbWt+Dgn5xul4w0FlFmXjKuEaI700= X-Received: from willmcvicker.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:2dd0]) (user=willmcvicker job=sendgmr) by 2002:a17:90a:3e04:b0:1ee:e899:4eb6 with SMTP id j4-20020a17090a3e0400b001eee8994eb6mr8179267pjc.187.1656543534620; Wed, 29 Jun 2022 15:58:54 -0700 (PDT) Date: Wed, 29 Jun 2022 22:58:42 +0000 In-Reply-To: <20220629225843.332453-1-willmcvicker@google.com> Message-Id: <20220629225843.332453-3-willmcvicker@google.com> Mime-Version: 1.0 References: <20220629225843.332453-1-willmcvicker@google.com> X-Mailer: git-send-email 2.37.0.rc0.161.g10f37bed90-goog Subject: [PATCH 4.19 v1 2/2] thermal/drivers/thermal_hwmon: Use hwmon_device_register_for_thermal() From: Will McVicker To: stable@vger.kernel.org, Jean Delvare , Guenter Roeck , Zhang Rui , Eduardo Valentin , Daniel Lezcano Cc: kernel-team@android.com, Will McVicker , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J . Wysocki" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck [ upstream commit 87743bcf08072b3e1952a0bf5524b2833e667b4c ] The thermal subsystem registers a hwmon device without providing chip information or sysfs attribute groups. While undesirable, it would be difficult to change. On the other side, it abuses the hwmon_device_register_with_info API by not providing that information. Use new API specifically created for the thermal subsystem instead to let us enforce the 'chip' parameter for other callers of hwmon_device_register_with_info(). Acked-by: Rafael J . Wysocki Signed-off-by: Guenter Roeck --- drivers/thermal/thermal_hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c index dd5d8ee37928..b3b229421936 100644 --- a/drivers/thermal/thermal_hwmon.c +++ b/drivers/thermal/thermal_hwmon.c @@ -147,8 +147,8 @@ int thermal_add_hwmon_sysfs(struct thermal_zone_device *tz) INIT_LIST_HEAD(&hwmon->tz_list); strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH); strreplace(hwmon->type, '-', '_'); - hwmon->device = hwmon_device_register_with_info(&tz->device, hwmon->type, - hwmon, NULL, NULL); + hwmon->device = hwmon_device_register_for_thermal(&tz->device, + hwmon->type, hwmon); if (IS_ERR(hwmon->device)) { result = PTR_ERR(hwmon->device); goto free_mem; -- 2.37.0.rc0.161.g10f37bed90-goog