* [PATCH -next] staging: r8188eu: remove unneeded semicolon
@ 2022-06-30 9:09 Yang Li
2022-06-30 11:58 ` Martin Kaiser
0 siblings, 1 reply; 4+ messages in thread
From: Yang Li @ 2022-06-30 9:09 UTC (permalink / raw)
To: Larry.Finger
Cc: phil, paskripkin, gregkh, linux-staging, linux-kernel, Yang Li
Eliminate the following coccicheck warning:
./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
index b5f6d41464db..5b0f66573d94 100644
--- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
+++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
@@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
break;
default:
return false;
- };
+ }
do {
pwrcfgcmd = pwrseqcmd[aryidx];
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon
2022-06-30 9:09 [PATCH -next] staging: r8188eu: remove unneeded semicolon Yang Li
@ 2022-06-30 11:58 ` Martin Kaiser
2022-07-01 19:58 ` Pavel Skripkin
0 siblings, 1 reply; 4+ messages in thread
From: Martin Kaiser @ 2022-06-30 11:58 UTC (permalink / raw)
To: Yang Li; +Cc: Larry.Finger, phil, paskripkin, gregkh, linux-staging,
linux-kernel
Thus wrote Yang Li (yang.lee@linux.alibaba.com):
> Eliminate the following coccicheck warning:
> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> index b5f6d41464db..5b0f66573d94 100644
> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
> break;
> default:
> return false;
> - };
> + }
> do {
> pwrcfgcmd = pwrseqcmd[aryidx];
> --
> 2.20.1.7.g153144c
Thanks for spotting this.
Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon
2022-06-30 11:58 ` Martin Kaiser
@ 2022-07-01 19:58 ` Pavel Skripkin
2022-07-04 12:04 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Skripkin @ 2022-07-01 19:58 UTC (permalink / raw)
To: Martin Kaiser, Yang Li
Cc: Larry.Finger, phil, gregkh, linux-staging, linux-kernel
Hi Martin,
Martin Kaiser <lists@kaiser.cx> says:
> Thus wrote Yang Li (yang.lee@linux.alibaba.com):
>
>> Eliminate the following coccicheck warning:
>> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>> drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> index b5f6d41464db..5b0f66573d94 100644
>> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
>> break;
>> default:
>> return false;
>> - };
>> + }
>
>> do {
>> pwrcfgcmd = pwrseqcmd[aryidx];
>> --
>> 2.20.1.7.g153144c
>
> Thanks for spotting this.
>
> Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
^^^^^^^^^^^^^^^^^^^^^^^^^^
No need to backport code-style warning, so Fixes: is not needed here.
Thanks,
--Pavel Skripkin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon
2022-07-01 19:58 ` Pavel Skripkin
@ 2022-07-04 12:04 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-07-04 12:04 UTC (permalink / raw)
To: Pavel Skripkin
Cc: Martin Kaiser, Yang Li, Larry.Finger, phil, gregkh, linux-staging,
linux-kernel
On Fri, Jul 01, 2022 at 10:58:58PM +0300, Pavel Skripkin wrote:
> Hi Martin,
>
> Martin Kaiser <lists@kaiser.cx> says:
> > Thus wrote Yang Li (yang.lee@linux.alibaba.com):
> >
> > > Eliminate the following coccicheck warning:
> > > ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> >
> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > > ---
> > > drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > > diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > index b5f6d41464db..5b0f66573d94 100644
> > > --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
> > > break;
> > > default:
> > > return false;
> > > - };
> > > + }
> >
> > > do {
> > > pwrcfgcmd = pwrseqcmd[aryidx];
> > > --
> > > 2.20.1.7.g153144c
> >
> > Thanks for spotting this.
> >
> > Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> No need to backport code-style warning, so Fixes: is not needed here.
>
The Fixes tag doesn't have to do with backporting...
I do think it should only be used for bugs. So I would not have used it
here. But other people do encourage it for style issues so I have given
up fighting about that.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-04 12:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-30 9:09 [PATCH -next] staging: r8188eu: remove unneeded semicolon Yang Li
2022-06-30 11:58 ` Martin Kaiser
2022-07-01 19:58 ` Pavel Skripkin
2022-07-04 12:04 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox