public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Alexandru Ardelean" <ardeleanalex@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Jonathan Cameron" <jic23@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, Florian Eckert <fe@dev.tdt.de>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-iio@vger.kernel.org>
Subject: [PATCH 2/2] iio: adc: ti-adc128s052: Add lower resolution devices support
Date: Thu, 30 Jun 2022 23:29:19 -0500	[thread overview]
Message-ID: <20220701042919.18180-3-nm@ti.com> (raw)
In-Reply-To: <20220701042919.18180-1-nm@ti.com>

The adcxx4s communicates with a host processor via an SPI/Microwire Bus
interface. The device family responds with 12bit data, of which the LSB
bits are transmitted by the lower resolution devices as 0. We don't need
to mess with ADC108S102_BITS as a result for the lower resolution
devices.

I have been able to test adc102s051, hence adding just the missing
ones in that family.

Lets reuse the driver to support the family of devices with name
ADC<bb><c>S<sss>, where
* bb is the resolution in number of bits (8, 10, 12)
* c is the number of channels (1, 2, 4, 8)
* sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
  and 101 for 1 MSPS)

Complete datasheets are available at TI's website here:
  https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf

Also see: drivers/hwmon/adcxx.c

Signed-off-by: Nishanth Menon <nm@ti.com>
---

This does add on additional sparse warnings around casting .data value
to const from int for the of_match_table, and a bunch around the .cls
field for acpi_device_id - maybe someone could suggest a smarter way to
fix those.

Applies after https://lore.kernel.org/linux-iio/20220630230107.13438-1-nm@ti.com/

 drivers/iio/adc/ti-adc128s052.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
index 21a7764cbb93..0a3aab4df60e 100644
--- a/drivers/iio/adc/ti-adc128s052.c
+++ b/drivers/iio/adc/ti-adc128s052.c
@@ -7,6 +7,20 @@
  * https://www.ti.com/lit/ds/symlink/adc128s052.pdf
  * https://www.ti.com/lit/ds/symlink/adc122s021.pdf
  * https://www.ti.com/lit/ds/symlink/adc124s021.pdf
+ *
+ * The adcxx4s communicates with a host processor via an SPI/Microwire Bus
+ * interface. This driver supports the whole family of devices with name
+ * ADC<bb><c>S<sss>, where
+ * bb is the resolution in number of bits (8, 10, 12)
+ * c is the number of channels (1, 2, 4, 8)
+ * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
+ * and 101 for 1 MSPS)
+ *
+ * Complete datasheets are available at TI's website here:
+ *   https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf
+ *
+ * Handling of 8, 10 and 12 bits converters are the same, the
+ * unavailable bits are 0 in LSB :)
  */
 
 #include <linux/acpi.h>
@@ -185,6 +199,12 @@ static const struct of_device_id adc128_of_match[] = {
 	{ .compatible = "ti,adc122s021", .data = 1},
 	{ .compatible = "ti,adc122s051", .data = 1},
 	{ .compatible = "ti,adc122s101", .data = 1},
+	{ .compatible = "ti,adc102s021", .data = 1},
+	{ .compatible = "ti,adc102s051", .data = 1},
+	{ .compatible = "ti,adc102s101", .data = 1},
+	{ .compatible = "ti,adc082s021", .data = 1},
+	{ .compatible = "ti,adc082s051", .data = 1},
+	{ .compatible = "ti,adc082s101", .data = 1},
 	{ .compatible = "ti,adc124s021", .data = 2},
 	{ .compatible = "ti,adc124s051", .data = 2},
 	{ .compatible = "ti,adc124s101", .data = 2},
@@ -197,6 +217,12 @@ static const struct spi_device_id adc128_id[] = {
 	{ "adc122s021",	1 },
 	{ "adc122s051",	1 },
 	{ "adc122s101",	1 },
+	{ "adc102s021",	1 },
+	{ "adc102s051",	1 },
+	{ "adc102s101",	1 },
+	{ "adc082s021",	1 },
+	{ "adc082s051",	1 },
+	{ "adc082s101",	1 },
 	{ "adc124s021", 2 },
 	{ "adc124s051", 2 },
 	{ "adc124s101", 2 },
-- 
2.31.1


  parent reply	other threads:[~2022-07-01  4:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01  4:29 [PATCH 0/2] iio: adc: ti-adc128s052: Add support for adc102s021 and family Nishanth Menon
2022-07-01  4:29 ` [PATCH 1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family Nishanth Menon
2022-07-01  6:38   ` Krzysztof Kozlowski
2022-07-01  8:27     ` Krzysztof Kozlowski
2022-07-01  4:29 ` Nishanth Menon [this message]
2022-07-01 16:40   ` [PATCH 2/2] iio: adc: ti-adc128s052: Add lower resolution devices support Jonathan Cameron
2022-07-06 18:06     ` Nishanth Menon
  -- strict thread matches above, loose matches on Subject: below --
2025-04-08 13:21 [PATCH 0/2] iio: adc: ti-adc128s052: Add support for adc102s021 Sukrut Bellary
2025-04-08 13:21 ` [PATCH 2/2] iio: adc: ti-adc128s052: Add lower resolution devices support Sukrut Bellary
2025-04-08 20:57   ` David Lechner
2025-04-09 21:42     ` Sukrut Bellary
2025-04-12 13:12   ` Jonathan Cameron
2025-04-15 22:20     ` Sukrut Bellary
2025-04-16  5:58       ` Matti Vaittinen
2025-04-14  6:40   ` Matti Vaittinen
2025-04-14 14:52     ` Nishanth Menon
2025-04-15 22:25     ` Sukrut Bellary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220701042919.18180-3-nm@ti.com \
    --to=nm@ti.com \
    --cc=angelo.compagnucci@gmail.com \
    --cc=ardeleanalex@gmail.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=fe@dev.tdt.de \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox