From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4296BC433EF for ; Fri, 1 Jul 2022 11:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236207AbiGALET (ORCPT ); Fri, 1 Jul 2022 07:04:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235475AbiGALEQ (ORCPT ); Fri, 1 Jul 2022 07:04:16 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C69F16758C for ; Fri, 1 Jul 2022 04:04:15 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7ERZ-0003NJ-L6; Fri, 01 Jul 2022 13:04:13 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1o7ERY-0000ZO-6r; Fri, 01 Jul 2022 13:04:12 +0200 Date: Fri, 1 Jul 2022 13:04:12 +0200 From: Oleksij Rempel To: Vladimir Oltean Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , kernel@pengutronix.de, Jakub Kicinski , Paolo Abeni , Vivien Didelot Subject: Re: [PATCH net-next v1 1/1] net: dsa: sja1105: silent spi_device_id warnings Message-ID: <20220701110412.GA24373@pengutronix.de> References: <20220630071013.1710594-1-o.rempel@pengutronix.de> <20220630161059.jnmladythszbh7py@skbuf> <20220701071835.GC951@pengutronix.de> <20220701102024.ewlnhtnjrpnukim5@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220701102024.ewlnhtnjrpnukim5@skbuf> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 01:20:24PM +0300, Vladimir Oltean wrote: > On Fri, Jul 01, 2022 at 09:18:35AM +0200, Oleksij Rempel wrote: > > Without this patch, module is not automatically loaded on my testing > > system. > > Ok, in that case do we need to target 'net' and split the patch into 2, > one with Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch") > and one with Fixes: 3e77e59bf8cf ("net: dsa: sja1105: add support for the SJA1110 switch family")? Hard to say, it looks like no one reported module autoload issue till kernel started warn about missing spi_device_id. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |