Re: [PATCH v2 2/5] dt-bindings: net: broadcom-bluetooth: Add conditional constraints

Linus Walleij
2022-07-11T08:34:07Z

On Thu, Jun 30, 2022 at 2:46 PM Hakan Jansson
<hakan.jansson@infineon.com> wrote:

> Add conditional constraint to make property "reset-gpios" available only
> for compatible devices acually having the reset pin.
>
> Make property "brcm,requires-autobaud-mode" depend on property
> "shutdown-gpios" as the shutdown pin is required to enter autobaud mode.
>
> I looked at all compatible devices and compiled the matrix below before
> formulating the conditional constraint. This was a pure paper exercise and
> no verification testing has been performed.
>
> d
> e
> v h
> i o
> c s
> s e t
> h - -
> u w w v
> t r a a v d
> d e k k b d
> o s e e a i
> w e u u t o
> n t p p - -
> - - - - s s
> g g g g u u
> p p p p t p p
> i i i i x l p p
> o o o o c p l l
> s s s s o o y y
> ---------------------------------------
> brcm,bcm20702a1 X X X X X X X X
> brcm,bcm4329-bt X X X X X X X X
> brcm,bcm4330-bt X X X X X X X X
> brcm,bcm4334-bt X - X X X X X X
> brcm,bcm43438-bt X - X X X X X X
> brcm,bcm4345c5 X - X X X X X X
> brcm,bcm43540-bt X - X X X X X X
> brcm,bcm4335a0 X - X X X X X X
> brcm,bcm4349-bt X - X X X X X X
> infineon,cyw55572-bt X - X X X X X X
>
> Signed-off-by: Hakan Jansson <hakan.jansson@infineon.com>

A job well done!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij