Re: [PATCH v12 net-next 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration

Andy Shevchenko
2022-07-01T20:25:29Z

On Fri, Jul 1, 2022 at 9:26 PM Colin Foster
<colin.foster@in-advantage.com> wrote:
>
> There are a few Ocelot chips that contain the logic for this bus, but are
> controlled externally. Specifically the VSC7511, 7512, 7513, and 7514. In
> the externally controlled configurations these registers are not
> memory-mapped.
>
> Add support for these non-memory-mapped configurations.

...

> + phy_regmap = ocelot_regmap_from_resource_optional(pdev, 1,
> + &mscc_miim_phy_regmap_config);
> + if (IS_ERR(phy_regmap)) {
> + dev_err(dev, "Unable to create phy register regmap\n");
> + return PTR_ERR(phy_regmap);

return dev_err_probe(...); ?

> }

--
With Best Regards,
Andy Shevchenko