From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B41EC43334 for ; Mon, 4 Jul 2022 06:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232441AbiGDGLJ (ORCPT ); Mon, 4 Jul 2022 02:11:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231444AbiGDGLH (ORCPT ); Mon, 4 Jul 2022 02:11:07 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C488C2BCD for ; Sun, 3 Jul 2022 23:11:06 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 99CC168AA6; Mon, 4 Jul 2022 08:11:03 +0200 (CEST) Date: Mon, 4 Jul 2022 08:11:03 +0200 From: Christoph Hellwig To: Steven Rostedt Cc: Christoph Hellwig , Jens Axboe , LKML Subject: Re: __dynamic_array() of 1 in blktrace? Message-ID: <20220704061103.GA29005@lst.de> References: <20220701122400.5a0f367e@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701122400.5a0f367e@gandalf.local.home> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 12:24:00PM -0400, Steven Rostedt wrote: > Is this to keep backward compatibility with user space? I think so. This used to trace the SCSI CDB when that was still part of the block layer. > does it need to be a dynamic array? I have no idea. We can try it and see if anyone complains.