__dynamic_array() of 1 in blktrace?

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* __dynamic_array() of 1 in blktrace?
@ 2022-07-01 16:24 Steven Rostedt
  2022-07-04  6:11 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2022-07-01 16:24 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Jens Axboe, LKML

Hi,

I'm adding a __vstring() to remove all the open coded vsprintf() calls in
events, and came across several of theses in include/trace/events/block:

		__dynamic_array( char,  cmd,    1)

[..]

		__get_str(cmd)[0] = '\0';

Is this to keep backward compatibility with user space?

does it need to be a dynamic array?

-- Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: __dynamic_array() of 1 in blktrace?
  2022-07-01 16:24 __dynamic_array() of 1 in blktrace? Steven Rostedt
@ 2022-07-04  6:11 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2022-07-04  6:11 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Christoph Hellwig, Jens Axboe, LKML

On Fri, Jul 01, 2022 at 12:24:00PM -0400, Steven Rostedt wrote:
> Is this to keep backward compatibility with user space?

I think so.  This used to trace the SCSI CDB when that was still
part of the block layer.

> does it need to be a dynamic array?

I have no idea.  We can try it and see if anyone complains.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-04  6:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-01 16:24 __dynamic_array() of 1 in blktrace? Steven Rostedt
2022-07-04  6:11 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox