Re: [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding

Pali Rohár
2022-07-07T12:27:38Z

On Wednesday 06 July 2022 09:07:26 Rob Herring wrote:
> On Tue, Jul 05, 2022 at 02:10:22AM +0200, Pali Rohár wrote:
> > GPIO is optional and used for WDI logic.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > Changes in v3:
> > * Extend description
> > ---
> > Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > index ab9641e845db..a0cf9e6c371d 100644
> > --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > @@ -27,6 +27,10 @@ properties:
> > description: This is a 1-byte memory-mapped address
> > maxItems: 1
> >
> > + gpios:
>
> As I said before, add a name prefix: wdi-gpios

So gpio with output direction should be really named that is input?

I really do not understand this kind of thinking and making every device
tree description totally illogical and inconsistent with all other.

> > + description: Optional GPIO used for controlling WDI (watchdog input) when WDI bit is not mapped to memory
>
> Wrap lines at 80 unless wrapping at 100 provides some benefit.
>
> yamllint is set to 110 because I don't want to fix everyone's line wrap,
> not because that's the standard.
>
>
> > + maxItems: 1
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.20.1
> >
> >