From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
Cc: Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Zhu Tony <tony.zhu@intel.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Lu Baolu <baolu.lu@linux.intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: [PATCH v10 05/12] iommu: Add IOMMU SVA domain support
Date: Tue, 5 Jul 2022 13:07:03 +0800 [thread overview]
Message-ID: <20220705050710.2887204-6-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
The sva iommu_domain represents a hardware pagetable that the IOMMU
hardware could use for SVA translation. This adds some infrastructure
to support SVA domain in the iommu common layer. It includes:
- Extend the iommu_domain to support a new IOMMU_DOMAIN_SVA domain
type. The IOMMU drivers that support allocation of the SVA domain
should provide its own sva domain specific iommu_domain_ops.
- Add a helper to allocate an SVA domain. The iommu_domain_free()
is still used to free an SVA domain.
The report_iommu_fault() should be replaced by the new
iommu_report_device_fault(). Leave the existing fault handler with the
existing users and the newly added SVA members excludes it.
Suggested-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Tested-by: Tony Zhu <tony.zhu@intel.com>
---
include/linux/iommu.h | 24 ++++++++++++++++++++++--
drivers/iommu/iommu.c | 20 ++++++++++++++++++++
2 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index f2b5aa7efe43..42f0418dc22c 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -64,6 +64,8 @@ struct iommu_domain_geometry {
#define __IOMMU_DOMAIN_PT (1U << 2) /* Domain is identity mapped */
#define __IOMMU_DOMAIN_DMA_FQ (1U << 3) /* DMA-API uses flush queue */
+#define __IOMMU_DOMAIN_SVA (1U << 4) /* Shared process address space */
+
/*
* This are the possible domain-types
*
@@ -77,6 +79,8 @@ struct iommu_domain_geometry {
* certain optimizations for these domains
* IOMMU_DOMAIN_DMA_FQ - As above, but definitely using batched TLB
* invalidation.
+ * IOMMU_DOMAIN_SVA - DMA addresses are shared process address
+ * spaces represented by mm_struct's.
*/
#define IOMMU_DOMAIN_BLOCKED (0U)
#define IOMMU_DOMAIN_IDENTITY (__IOMMU_DOMAIN_PT)
@@ -86,15 +90,23 @@ struct iommu_domain_geometry {
#define IOMMU_DOMAIN_DMA_FQ (__IOMMU_DOMAIN_PAGING | \
__IOMMU_DOMAIN_DMA_API | \
__IOMMU_DOMAIN_DMA_FQ)
+#define IOMMU_DOMAIN_SVA (__IOMMU_DOMAIN_SVA)
struct iommu_domain {
unsigned type;
const struct iommu_domain_ops *ops;
unsigned long pgsize_bitmap; /* Bitmap of page sizes in use */
- iommu_fault_handler_t handler;
- void *handler_token;
struct iommu_domain_geometry geometry;
struct iommu_dma_cookie *iova_cookie;
+ union {
+ struct {
+ iommu_fault_handler_t handler;
+ void *handler_token;
+ };
+ struct { /* IOMMU_DOMAIN_SVA */
+ struct mm_struct *mm;
+ };
+ };
};
static inline bool iommu_is_dma_domain(struct iommu_domain *domain)
@@ -685,6 +697,8 @@ int iommu_group_claim_dma_owner(struct iommu_group *group, void *owner);
void iommu_group_release_dma_owner(struct iommu_group *group);
bool iommu_group_dma_owner_claimed(struct iommu_group *group);
+struct iommu_domain *iommu_sva_domain_alloc(struct device *dev,
+ struct mm_struct *mm);
int iommu_attach_device_pasid(struct iommu_domain *domain, struct device *dev,
ioasid_t pasid);
void iommu_detach_device_pasid(struct iommu_domain *domain, struct device *dev,
@@ -1063,6 +1077,12 @@ static inline bool iommu_group_dma_owner_claimed(struct iommu_group *group)
return false;
}
+static inline struct iommu_domain *
+iommu_sva_domain_alloc(struct device *dev, struct mm_struct *mm)
+{
+ return NULL;
+}
+
static inline int iommu_attach_device_pasid(struct iommu_domain *domain,
struct device *dev, ioasid_t pasid)
{
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index be48b09371f4..10479c5e4d23 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -27,6 +27,7 @@
#include <linux/module.h>
#include <linux/cc_platform.h>
#include <trace/events/iommu.h>
+#include <linux/sched/mm.h>
static struct kset *iommu_group_kset;
static DEFINE_IDA(iommu_group_ida);
@@ -1957,6 +1958,8 @@ EXPORT_SYMBOL_GPL(iommu_domain_alloc);
void iommu_domain_free(struct iommu_domain *domain)
{
+ if (domain->type == IOMMU_DOMAIN_SVA)
+ mmdrop(domain->mm);
iommu_put_dma_cookie(domain);
domain->ops->free(domain);
}
@@ -3274,6 +3277,23 @@ bool iommu_group_dma_owner_claimed(struct iommu_group *group)
}
EXPORT_SYMBOL_GPL(iommu_group_dma_owner_claimed);
+struct iommu_domain *iommu_sva_domain_alloc(struct device *dev,
+ struct mm_struct *mm)
+{
+ const struct iommu_ops *ops = dev_iommu_ops(dev);
+ struct iommu_domain *domain;
+
+ domain = ops->domain_alloc(IOMMU_DOMAIN_SVA);
+ if (!domain)
+ return NULL;
+
+ domain->type = IOMMU_DOMAIN_SVA;
+ mmgrab(mm);
+ domain->mm = mm;
+
+ return domain;
+}
+
static bool iommu_group_immutable_singleton(struct iommu_group *group,
struct device *dev)
{
--
2.25.1
next prev parent reply other threads:[~2022-07-05 5:12 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 5:06 [PATCH v10 00/12] iommu: SVA and IOPF refactoring Lu Baolu
2022-07-05 5:06 ` [PATCH v10 01/12] iommu: Add max_pasids field in struct iommu_device Lu Baolu
2022-07-23 13:57 ` Jason Gunthorpe
2022-07-31 11:54 ` Yi Liu
2022-07-31 13:33 ` Baolu Lu
2022-07-05 5:07 ` [PATCH v10 02/12] iommu: Add max_pasids field in struct dev_iommu Lu Baolu
2022-07-23 14:02 ` Jason Gunthorpe
2022-07-31 11:55 ` Yi Liu
2022-07-05 5:07 ` [PATCH v10 03/12] iommu: Remove SVM_FLAG_SUPERVISOR_MODE support Lu Baolu
2022-07-31 12:01 ` Yi Liu
2022-07-31 13:39 ` Baolu Lu
2022-07-05 5:07 ` [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu interface Lu Baolu
2022-07-07 1:51 ` Tian, Kevin
2022-07-23 14:11 ` Jason Gunthorpe
2022-07-24 7:03 ` Baolu Lu
2022-07-25 14:40 ` Jason Gunthorpe
2022-07-26 6:23 ` Baolu Lu
2022-07-26 13:57 ` Jason Gunthorpe
2022-07-27 3:20 ` Tian, Kevin
2022-07-27 11:53 ` Jason Gunthorpe
2022-07-28 3:06 ` Tian, Kevin
2022-07-28 11:59 ` Jason Gunthorpe
2022-07-29 2:49 ` Baolu Lu
2022-07-29 2:56 ` Tian, Kevin
2022-07-29 3:20 ` Baolu Lu
2022-07-29 4:22 ` Tian, Kevin
2022-07-30 6:17 ` Baolu Lu
2022-07-29 2:51 ` Tian, Kevin
2022-07-29 12:22 ` Jason Gunthorpe
2022-07-30 6:23 ` Baolu Lu
2022-07-28 2:44 ` Baolu Lu
2022-07-28 6:27 ` Baolu Lu
2022-08-02 2:19 ` Baolu Lu
2022-08-02 12:37 ` Jason Gunthorpe
2022-08-03 13:07 ` Baolu Lu
2022-08-03 19:03 ` Jason Gunthorpe
2022-08-04 2:03 ` Tian, Kevin
2022-08-04 2:42 ` Baolu Lu
2022-07-24 7:23 ` Baolu Lu
2022-07-24 8:39 ` Baolu Lu
2022-07-24 9:13 ` Baolu Lu
2022-07-25 7:46 ` Tian, Kevin
2022-07-25 10:11 ` Baolu Lu
2022-07-31 12:10 ` Yi Liu
2022-07-05 5:07 ` Lu Baolu [this message]
2022-07-07 1:52 ` [PATCH v10 05/12] iommu: Add IOMMU SVA domain support Tian, Kevin
2022-07-07 3:01 ` Baolu Lu
2022-07-23 14:15 ` Jason Gunthorpe
2022-07-31 12:19 ` Yi Liu
2022-07-05 5:07 ` [PATCH v10 06/12] iommu/vt-d: Add " Lu Baolu
2022-07-23 14:16 ` Jason Gunthorpe
2022-07-31 12:20 ` Yi Liu
2022-07-05 5:07 ` [PATCH v10 07/12] arm-smmu-v3/sva: " Lu Baolu
2022-07-23 14:20 ` Jason Gunthorpe
2022-07-24 11:58 ` Baolu Lu
2022-07-05 5:07 ` [PATCH v10 08/12] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Lu Baolu
2022-07-05 17:43 ` Jean-Philippe Brucker
2022-07-07 1:56 ` Tian, Kevin
2022-07-07 3:02 ` Baolu Lu
2022-07-23 14:26 ` Jason Gunthorpe
2022-07-24 13:48 ` Baolu Lu
2022-07-25 7:39 ` Jean-Philippe Brucker
2022-07-25 8:02 ` Tian, Kevin
2022-07-25 8:47 ` Jean-Philippe Brucker
2022-07-25 9:33 ` Baolu Lu
2022-07-25 9:52 ` Jean-Philippe Brucker
2022-07-25 14:46 ` Jason Gunthorpe
2022-07-25 7:50 ` Tian, Kevin
2022-07-25 10:22 ` Baolu Lu
2022-07-25 14:47 ` Jason Gunthorpe
2022-07-26 8:47 ` Baolu Lu
2022-07-31 12:36 ` Yi Liu
2022-07-31 13:45 ` Baolu Lu
2022-07-31 12:55 ` Yi Liu
2022-07-31 13:51 ` Baolu Lu
2022-07-05 5:07 ` [PATCH v10 09/12] iommu: Remove SVA related callbacks from iommu ops Lu Baolu
2022-07-23 14:27 ` Jason Gunthorpe
2022-07-31 12:38 ` Yi Liu
2022-07-05 5:07 ` [PATCH v10 10/12] iommu: Prepare IOMMU domain for IOPF Lu Baolu
2022-07-07 1:58 ` Tian, Kevin
2022-07-23 14:33 ` Jason Gunthorpe
2022-07-24 14:04 ` Baolu Lu
2022-07-25 14:49 ` Jason Gunthorpe
2022-07-31 12:50 ` Yi Liu
2022-07-31 13:47 ` Baolu Lu
2022-07-05 5:07 ` [PATCH v10 11/12] iommu: Per-domain I/O page fault handling Lu Baolu
2022-07-07 2:06 ` Tian, Kevin
2022-07-23 14:34 ` Jason Gunthorpe
2022-07-05 5:07 ` [PATCH v10 12/12] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu
2022-07-23 14:34 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705050710.2887204-6-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=dave.jiang@intel.com \
--cc=eric.auger@redhat.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@intel.com \
--cc=jean-philippe@linaro.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=tony.zhu@intel.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox