Re: [PATCH 09/14] arm64: dts: qcom: sc8280xp: drop UFS PHY clock-cells

Dmitry Baryshkov
2022-07-05T13:42:55Z

On 05/07/2022 14:40, Johan Hovold wrote:
> The QMP UFS PHY provides more than one symbol clock and would need an
> index to differentiate the clocks, but none of this is described by the
> binding currently.
>
> Drop the incorrect '#clock-cells' property for now.

Could you please take a glance whether
https://lore.kernel.org/linux-arm-msm/20220620153956.1723269-2-dmitry.baryshkov@linaro.org/
makes a sense to the sc8280xp platform?

>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 345a19a6e874..ce4df4e814fe 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1447,7 +1447,6 @@ ufs_mem_phy_lanes: phy@1d87400 {
> <0 0x01d87800 0 0x108>,
> <0 0x01d87a00 0 0x1e0>;
> #phy-cells = <0>;
> - #clock-cells = <0>;
> };
> };
>
> @@ -1517,7 +1516,6 @@ ufs_card_phy_lanes: phy@1da7400 {
> <0 0x01da7800 0 0x108>,
> <0 0x01da7a00 0 0x1e0>;
> #phy-cells = <0>;
> - #clock-cells = <0>;
> };
> };
>

--
With best wishes
Dmitry