From: Max Staudt <max@enpas.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org,
Vincent Mailhol <vincent.mailhol@gmail.com>,
Oliver Neukum <oneukum@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Tue, 5 Jul 2022 11:56:13 +0200 [thread overview]
Message-ID: <20220705115613.69d32b22.max@enpas.org> (raw)
In-Reply-To: <20220705094927.vgtxcjh4klw6dcg3@pengutronix.de>
On Tue, 5 Jul 2022 11:49:27 +0200
Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 05.07.2022 11:43:52, Geert Uytterhoeven wrote:
> > So development started before commit cd6484e1830be260 ("serdev:
> > Introduce new bus for serial attached devices"). I guess that is
> > the reason why this driver uses a line discipline, instead of the
> > serial bus?
> >
> > I had a quick glance through the various revisions posted, and it
> > doesn't seem like anyone mentioned the serial bus. Would there be
> > any advantage in migrating to the serial bus?
>
> Does serial bus work with hot plug devices like USB Serial Adapters
> and/or devices that are not described in the device tree?
This is indeed the reason. The device cannot be autodetected, as the
UART has no identifying information (USB VID/PID or the like, and don't
forget the BT variants) attached to it, hence the manual attachment.
Max
next prev parent reply other threads:[~2022-07-05 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 19:50 [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-06-18 22:02 ` kernel test robot
2022-06-19 8:08 ` Marc Kleine-Budde
2022-06-27 15:05 ` Marc Kleine-Budde
2022-06-27 17:01 ` Max Staudt
2022-07-05 9:43 ` Geert Uytterhoeven
2022-07-05 9:49 ` Marc Kleine-Budde
2022-07-05 9:56 ` Max Staudt [this message]
2022-07-05 10:16 ` Geert Uytterhoeven
2022-07-05 10:39 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705115613.69d32b22.max@enpas.org \
--to=max@enpas.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=oneukum@suse.com \
--cc=socketcan@hartkopp.net \
--cc=vincent.mailhol@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox