Re: [PATCH 5.15 96/98] hwmon: (occ) Remove sequence numbering and checksum calculation

Greg Kroah-Hartman
2022-07-06T07:03:01Z

On Wed, Jul 06, 2022 at 06:43:47AM +0000, Joel Stanley wrote:
> On Tue, 5 Jul 2022 at 12:14, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > From: Eddie James <eajames@linux.ibm.com>
> >
> > [ Upstream commit 908dbf0242e21dd95c69a1b0935814cd1abfc134 ]
> >
> > Checksumming of the request and sequence numbering is now done in the
> > OCC interface driver in order to keep unique sequence numbers. So
> > remove those in the hwmon driver. Also, add the command length to the
> > send_cmd function pointer, since the checksum must be placed in the
> > last two bytes of the command. The submit interface must receive the
> > exact size of the command - previously it could be rounded to the
> > nearest 8 bytes with no consequence.
> >
> > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > Link: https://lore.kernel.org/r/20210721190231.117185-3-eajames@linux.ibm.com
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> If this patch is being backported then we must also backport:
>
> 62f79f3d0eb9 ("fsi: occ: Force sequence numbering per OCC")
>
> I was only cc'd on this one so I assume that means 62f79f3d0eb9 is not
> already in the queue.

It was not, so I have now added it, thanks.

greg k-h