* [PATCH v2 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions
@ 2022-07-05 15:52 Andy Shevchenko
2022-07-06 12:10 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-07-05 15:52 UTC (permalink / raw)
To: Andy Shevchenko, alsa-devel, patches, linux-kernel
Cc: Charles Keepax, Richard Fitzgerald, Jaroslav Kysela, Takashi Iwai,
Liam Girdwood, Mark Brown
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
v2: added tag (Richard), Cc'ed ASoC maintainers
include/sound/madera-pdata.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/sound/madera-pdata.h b/include/sound/madera-pdata.h
index e3060f48f108..58398d80c3de 100644
--- a/include/sound/madera-pdata.h
+++ b/include/sound/madera-pdata.h
@@ -9,7 +9,7 @@
#ifndef MADERA_CODEC_PDATA_H
#define MADERA_CODEC_PDATA_H
-#include <linux/kernel.h>
+#include <linux/types.h>
#define MADERA_MAX_INPUT 6
#define MADERA_MAX_MUXED_CHANNELS 4
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions
2022-07-05 15:52 [PATCH v2 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions Andy Shevchenko
@ 2022-07-06 12:10 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2022-07-06 12:10 UTC (permalink / raw)
To: Andy Shevchenko
Cc: alsa-devel, patches, linux-kernel, Richard Fitzgerald,
Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Mark Brown
On Tue, Jul 05, 2022 at 06:52:39PM +0300, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-06 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-05 15:52 [PATCH v2 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions Andy Shevchenko
2022-07-06 12:10 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).