* [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family
@ 2022-07-05 2:57 Jimmy Chen
2022-07-05 16:39 ` Rob Herring
2022-07-05 17:59 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Jimmy Chen @ 2022-07-05 2:57 UTC (permalink / raw)
To: LKML, Andy Gross
Cc: Rob Herring, Bjorn Andersson, Krzysztof Kozlowski,
Douglas Anderson, Konrad Dybcio, Alan Huang, devicetree,
linux-arm-msm
This adds a LTE skus for Chromebook Villager to the yaml.
Signed-off-by: Jimmy Chen <jinghung.chen3@hotmail.com>
---
The format of the added items is based on the below document.
Documentation/arm/google/chromebook-boot-flow.rst
Changes in v2:
- Update the patch title and the commit message
Changes in v3:
- Update patch title
---
Documentation/devicetree/bindings/arm/qcom.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 4dd18fbf20b68..a136b1389c2ac 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -529,11 +529,26 @@ properties:
- const: google,herobrine
- const: qcom,sc7280
+ - description: Google Villager (rev0)
+ items:
+ - const: google,villager-rev0
+ - const: qcom,sc7280
+
- description: Google Villager (newest rev)
items:
- const: google,villager
- const: qcom,sc7280
+ - description: Google Villager with LTE (rev0)
+ items:
+ - const: google,villager-rev0-sku0
+ - const: qcom,sc7280
+
+ - description: Google Villager with LTE (newest rev)
+ items:
+ - const: google,villager-sku0
+ - const: qcom,sc7280
+
- items:
- enum:
- lenovo,flex-5g
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family
2022-07-05 2:57 [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family Jimmy Chen
@ 2022-07-05 16:39 ` Rob Herring
2022-07-05 17:59 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-07-05 16:39 UTC (permalink / raw)
To: Jimmy Chen
Cc: LKML, Andy Gross, Bjorn Andersson, Krzysztof Kozlowski,
Douglas Anderson, Konrad Dybcio, Alan Huang, devicetree,
linux-arm-msm
On Tue, Jul 05, 2022 at 10:57:47AM +0800, Jimmy Chen wrote:
> This adds a LTE skus for Chromebook Villager to the yaml.
Your subject is wrong. This is not a .dts file change. Use 'git log
--oneline' for inspiration as to what the subject should look like for
this file/directory.
>
> Signed-off-by: Jimmy Chen <jinghung.chen3@hotmail.com>
> ---
>
> The format of the added items is based on the below document.
> Documentation/arm/google/chromebook-boot-flow.rst
>
> Changes in v2:
> - Update the patch title and the commit message
> Changes in v3:
> - Update patch title
>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 4dd18fbf20b68..a136b1389c2ac 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -529,11 +529,26 @@ properties:
> - const: google,herobrine
> - const: qcom,sc7280
>
> + - description: Google Villager (rev0)
> + items:
> + - const: google,villager-rev0
> + - const: qcom,sc7280
> +
> - description: Google Villager (newest rev)
> items:
> - const: google,villager
> - const: qcom,sc7280
>
> + - description: Google Villager with LTE (rev0)
> + items:
> + - const: google,villager-rev0-sku0
> + - const: qcom,sc7280
> +
> + - description: Google Villager with LTE (newest rev)
> + items:
> + - const: google,villager-sku0
> + - const: qcom,sc7280
> +
> - items:
> - enum:
> - lenovo,flex-5g
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family
2022-07-05 2:57 [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family Jimmy Chen
2022-07-05 16:39 ` Rob Herring
@ 2022-07-05 17:59 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-05 17:59 UTC (permalink / raw)
To: Jimmy Chen, LKML, Andy Gross
Cc: Rob Herring, Bjorn Andersson, Krzysztof Kozlowski,
Douglas Anderson, Konrad Dybcio, Alan Huang, devicetree,
linux-arm-msm
On 05/07/2022 04:57, Jimmy Chen wrote:
> This adds a LTE skus for Chromebook Villager to the yaml.
>
> Signed-off-by: Jimmy Chen <jinghung.chen3@hotmail.com>
> ---
>
> The format of the added items is based on the below document.
> Documentation/arm/google/chromebook-boot-flow.rst
>
> Changes in v2:
> - Update the patch title and the commit message
> Changes in v3:
> - Update patch title
It's still wrong. Not mentioning incorrect patch formatting.
You ignored my comment from previous version. Please respond to it. If
you prefer to ignore it, then it is a NAK.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-05 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-05 2:57 [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family Jimmy Chen
2022-07-05 16:39 ` Rob Herring
2022-07-05 17:59 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).