public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Marangi <ansuelsmth@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Christian Marangi <ansuelsmth@gmail.com>
Subject: [PATCH 1/5] dt-bindings: clock: fix wrong clock documentation for qcom,rpmcc
Date: Tue,  5 Jul 2022 22:28:33 +0200	[thread overview]
Message-ID: <20220705202837.667-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20220705202837.667-1-ansuelsmth@gmail.com>

qcom,rpmcc describe 2 different kind of device.
Currently we have definition for rpm-smd based device but we lack
Documentation for simple rpm based device.

Add the missing clk for ipq806x, apq8060, msm8660 and apq8064 and
provide and additional example.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 .../devicetree/bindings/clock/qcom,rpmcc.yaml | 77 ++++++++++++++++++-
 1 file changed, 73 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
index 9d296b89a8d0..028eb0277495 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
@@ -48,16 +48,65 @@ properties:
   '#clock-cells':
     const: 1
 
-  clocks:
-    maxItems: 1
+  clocks: true
 
-  clock-names:
-    const: xo
+  clock-names: true
 
 required:
   - compatible
   - '#clock-cells'
 
+if:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - qcom,rpmcc-apq8060
+          - qcom,rpmcc-ipq806x
+          - qcom,rpmcc-msm8660
+
+then:
+  properties:
+    clocks:
+      description: pxo clock
+
+    clock-names:
+      const: pxo
+
+  required:
+    - clocks
+    - clock-names
+
+else:
+  if:
+    properties:
+      compatible:
+        contains:
+          const: qcom,rpmcc-apq8064
+  then:
+    properties:
+      clocks:
+        items:
+          - description: pxo clock
+          - description: cxo clock
+
+      clock-names:
+        items:
+          - const: pxo
+          - const: cxo
+
+    required:
+      - clocks
+      - clock-names
+
+  else:
+    properties:
+      clocks:
+        description: xo clock
+
+      clock-names:
+        const: xo
+
 additionalProperties: false
 
 examples:
@@ -73,3 +122,23 @@ examples:
             };
         };
     };
+
+  - |
+    rpm {
+        clock-controller {
+            compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc";
+            #clock-cells = <1>;
+            clocks = <&pxo_board>;
+            clock-names = "pxo";
+        };
+    };
+
+  - |
+    rpm {
+        clock-controller {
+            compatible = "qcom,rpmcc-apq8064", "qcom,rpmcc";
+            #clock-cells = <1>;
+            clocks = <&pxo_board>, <&cxo_board>;
+            clock-names = "pxo", "cxo";
+        };
+    };
-- 
2.36.1


  reply	other threads:[~2022-07-05 20:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 20:28 [PATCH 0/5] clk: qcom: Drop use of pxo/cxo_board for rpm devices Christian Marangi
2022-07-05 20:28 ` Christian Marangi [this message]
2022-07-06  7:43   ` [PATCH 1/5] dt-bindings: clock: fix wrong clock documentation for qcom,rpmcc Krzysztof Kozlowski
2022-07-06  8:23   ` Dmitry Baryshkov
2022-07-06 10:19     ` Christian Marangi
2022-07-06 11:58       ` Dmitry Baryshkov
2022-07-05 20:28 ` [PATCH 2/5] ARM: DTS: qcom: fix dtbs_check warning with new rpmcc clocks Christian Marangi
2022-07-06  7:35   ` Dmitry Baryshkov
2022-07-06  7:44   ` Krzysztof Kozlowski
2022-07-06 10:20     ` Christian Marangi
2022-07-06 15:07       ` Krzysztof Kozlowski
2022-07-06 19:10         ` Christian Marangi
2022-07-06 20:09           ` Krzysztof Kozlowski
2022-07-06 20:38             ` Christian Marangi
2022-07-05 20:28 ` [PATCH 3/5] clk: qcom: clk-rpm: convert to parent_data API Christian Marangi
2022-07-06  8:27   ` Dmitry Baryshkov
2022-07-06 10:21     ` Christian Marangi
2022-07-06 13:26   ` Konrad Dybcio
2022-07-06 13:16     ` Christian Marangi
2022-07-05 20:28 ` [PATCH 4/5] ARM: dts: qcom: add pxo/cxo clock-output-names for ipq8064 Christian Marangi
2022-07-06  8:29   ` Dmitry Baryshkov
2022-07-06 10:22     ` Christian Marangi
2022-07-06 13:24   ` Konrad Dybcio
2022-07-05 20:28 ` [PATCH 5/5] clk: qcom: gcc-ipq806x: remove cc_register_board for pxo and cxo Christian Marangi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220705202837.667-2-ansuelsmth@gmail.com \
    --to=ansuelsmth@gmail.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox