From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>, Serge Semin <fancer.lancer@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write()
Date: Wed, 6 Jul 2022 13:40:24 +0300 [thread overview]
Message-ID: <20220706104024.GD2338@kadam> (raw)
In-Reply-To: <YsUyqwe9Caxb6k4g@kili>
On Wed, Jul 06, 2022 at 09:58:51AM +0300, Dan Carpenter wrote:
> The simple_write_to_buffer() here is used to copy a string from the
> user. However the function call will succeed if it manages to read
> just one byte anywhere within the buffer while we need the whole string
> to be initialized to avoid using uninitialized data.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
NAK. The strndup_user() function is too strict. I will resend this
using memdup_user() instead.
regards,
dan carpenter
next prev parent reply other threads:[~2022-07-06 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 6:58 [PATCH] eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write() Dan Carpenter
2022-07-06 10:40 ` Dan Carpenter [this message]
2022-07-07 18:06 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706104024.GD2338@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox