From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B4FCCA473 for ; Wed, 6 Jul 2022 15:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234156AbiGFPfg (ORCPT ); Wed, 6 Jul 2022 11:35:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234140AbiGFPev (ORCPT ); Wed, 6 Jul 2022 11:34:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB1452A41F; Wed, 6 Jul 2022 08:33:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 470D7B81D96; Wed, 6 Jul 2022 15:33:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF38EC385A2; Wed, 6 Jul 2022 15:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657121588; bh=bAIRwr6BEm+EAGgJYiIeXfINsAsI8XaB6jUr0p/oxfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vLWPvqc2U7rJZku/O76T6EtHsNbeppHxjPgWZss8EWpMI4DPB5NAjwMydJhDVSXAp VRywHfnHwpgA4vRPVd1ejk5rW2rJYqxyZk8jOn3VePzD5cLhoz55/hpVP+Sz2diuhP bKkeh8FKFs5vukqqOOLXcGPgn62LFJosge6D8VIaq+hDvTT2LiOn5J+krdTubFndHr q1ljWUW0H+rAqDyOPTyHcxTTZV1Ow/Dm8qEk4WwUFPdk2SP/488RUJTIjVHLDl3GCA rRU2fwbnykJ5YxArwAl5b/17jykftckjmh324Az1gle2FfVQOVwXFwseBx8HRRM3P0 tQQ9nUv2UPY3g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hangyu Hua , Tung Nguyen , "David S . Miller" , Sasha Levin , jmaloy@redhat.com, ying.xue@windriver.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.10 07/11] net: tipc: fix possible refcount leak in tipc_sk_create() Date: Wed, 6 Jul 2022 11:32:52 -0400 Message-Id: <20220706153256.1598411-7-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220706153256.1598411-1-sashal@kernel.org> References: <20220706153256.1598411-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hangyu Hua [ Upstream commit 00aff3590fc0a73bddd3b743863c14e76fd35c0c ] Free sk in case tipc_sk_insert() fails. Signed-off-by: Hangyu Hua Reviewed-by: Tung Nguyen Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 42283dc6c5b7..38256aabf4f1 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -489,6 +489,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock, sock_init_data(sock, sk); tipc_set_sk_state(sk, TIPC_OPEN); if (tipc_sk_insert(tsk)) { + sk_free(sk); pr_warn("Socket create failed; port number exhausted\n"); return -EINVAL; } -- 2.35.1