From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B3E0C43334 for ; Wed, 6 Jul 2022 15:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234455AbiGFPgk (ORCPT ); Wed, 6 Jul 2022 11:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234037AbiGFPfs (ORCPT ); Wed, 6 Jul 2022 11:35:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8881C18398; Wed, 6 Jul 2022 08:33:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2EC6BB81D97; Wed, 6 Jul 2022 15:33:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E0CEC341CE; Wed, 6 Jul 2022 15:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657121607; bh=+Tc7B7eHJsJlCG5mleBaegds+TrWSgEsBX0tpPnlfSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ITVEQKuODceghsLOC997As1VWj+LEfPIhh8gajBOwK1mkv9+qzALO2QQtZf/RMop/ 43I8TcFc/n2fBf3x177WkUc6lHC+85QlWRYlHC2g+p2jvD7BytQs+LlfG0Ai+kkHEb iI2vf/pt59zFBs8I+JgOz+ZJT7mWvhr2zC98e3hWt8wNQh3VMMa+ItcGBEF3mPDhCQ qLDuRxvbm8QAISd8LaKc+/dIwpnPXwMD4SuRJ1vSKdVikSkNW2/CvEYuJiePihg+1A NQaVU8f++K1/PDC5dx8M6XnMR3y5zFryl7NxkJRJ9fMCmG8EB5g+4JXrHjOUzSlfKe qsICR9UFrfrLA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hangyu Hua , Tung Nguyen , "David S . Miller" , Sasha Levin , jmaloy@redhat.com, ying.xue@windriver.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.4 6/9] net: tipc: fix possible refcount leak in tipc_sk_create() Date: Wed, 6 Jul 2022 11:33:12 -0400 Message-Id: <20220706153316.1598554-6-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220706153316.1598554-1-sashal@kernel.org> References: <20220706153316.1598554-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hangyu Hua [ Upstream commit 00aff3590fc0a73bddd3b743863c14e76fd35c0c ] Free sk in case tipc_sk_insert() fails. Signed-off-by: Hangyu Hua Reviewed-by: Tung Nguyen Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index d543c4556df2..58c4d61d603f 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -455,6 +455,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock, sock_init_data(sock, sk); tipc_set_sk_state(sk, TIPC_OPEN); if (tipc_sk_insert(tsk)) { + sk_free(sk); pr_warn("Socket create failed; port number exhausted\n"); return -EINVAL; } -- 2.35.1