[PATCH 2/2] Add an entry for MOXA platform board

[PATCH 2/2] Add an entry for MOXA platform board

[Jimmy Chen (陳永達)]

UC-8220 & UC-8210 hardware compatibility model

Signed-off-by: Jimmy Chen <jimmy.chen@moxa.com>
---
 .../devicetree/bindings/arm/moxa.yaml         | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/moxa.yaml

diff --git a/Documentation/devicetree/bindings/arm/moxa.yaml b/Documentation/devicetree/bindings/arm/moxa.yaml
new file mode 100644
index 000000000000..73f4bf883b06
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/moxa.yaml
@@ -0,0 +1,21 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/moxa.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MOXA platform device tree bindings
+
+maintainers:
+  - Jimmy Chen <jimmy.chen@moxa.com>
+
+properties:
+  compatible:
+    description: UC-82XX-LX embedded computer
+    items:
+      - const: moxa,uc-8210
+      - const: moxa,uc-8220
+
+additionalProperties: true
+...
+
-- 
2.20.1

Re: [PATCH 2/2] Add an entry for MOXA platform board

[Krzysztof Kozlowski]

On 06/07/2022 09:22, Jimmy Chen (陳永達) wrote:
> UC-8220 & UC-8210 hardware compatibility model
> 
> Signed-off-by: Jimmy Chen <jimmy.chen@moxa.com>
> ---
>  .../devicetree/bindings/arm/moxa.yaml         | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/moxa.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/moxa.yaml b/Documentation/devicetree/bindings/arm/moxa.yaml
> new file mode 100644
> index 000000000000..73f4bf883b06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/moxa.yaml
This goes to fsl file.

> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/moxa.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MOXA platform device tree bindings
> +
> +maintainers:
> +  - Jimmy Chen <jimmy.chen@moxa.com>
> +
> +properties:
> +  compatible:
> +    description: UC-82XX-LX embedded computer
> +    items:
> +      - const: moxa,uc-8210
> +      - const: moxa,uc-8220

Does not match your DTS and should fail the tests (dtbs_check).

Best regards,
Krzysztof

Re: [PATCH 2/2] Add an entry for MOXA platform board

[Rob Herring]

On Wed, Jul 06, 2022 at 07:22:23AM +0000, Jimmy Chen (陳永達) wrote:
> UC-8220 & UC-8210 hardware compatibility model
> 
> Signed-off-by: Jimmy Chen <jimmy.chen@moxa.com>
> ---
>  .../devicetree/bindings/arm/moxa.yaml         | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/moxa.yaml

What's the relationship to moxart.yaml?

> 
> diff --git a/Documentation/devicetree/bindings/arm/moxa.yaml b/Documentation/devicetree/bindings/arm/moxa.yaml
> new file mode 100644
> index 000000000000..73f4bf883b06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/moxa.yaml
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/moxa.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MOXA platform device tree bindings
> +
> +maintainers:
> +  - Jimmy Chen <jimmy.chen@moxa.com>
> +
> +properties:
> +  compatible:
> +    description: UC-82XX-LX embedded computer
> +    items:
> +      - const: moxa,uc-8210
> +      - const: moxa,uc-8220
> +
> +additionalProperties: true
> +...
> +
> -- 
> 2.20.1
> 

RE: [PATCH 2/2] Add an entry for MOXA platform board

[Jimmy Chen (陳永達)]

Rob,
	UC8210/8220 use Freescale CPU, UC7110/7112 use MoxaArt(moxart.yaml) proprietary MOXA CPU.

-----Original Message-----
From: Rob Herring <robh@kernel.org> 
Sent: Thursday, July 7, 2022 12:15 AM
To: Jimmy Chen (陳永達) <jimmy.chen@moxa.com>
Cc: krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Add an entry for MOXA platform board

On Wed, Jul 06, 2022 at 07:22:23AM +0000, Jimmy Chen (陳永達) wrote:
> UC-8220 & UC-8210 hardware compatibility model
> 
> Signed-off-by: Jimmy Chen <jimmy.chen@moxa.com>
> ---
>  .../devicetree/bindings/arm/moxa.yaml         | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/moxa.yaml

What's the relationship to moxart.yaml?

> 
> diff --git a/Documentation/devicetree/bindings/arm/moxa.yaml 
> b/Documentation/devicetree/bindings/arm/moxa.yaml
> new file mode 100644
> index 000000000000..73f4bf883b06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/moxa.yaml
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> +---
> +$id: 
> +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> +cetree.org%2Fschemas%2Farm%2Fmoxa.yaml%23&amp;data=05%7C01%7Cjimmy.ch
> +en%40moxa.com%7Cb1a7593190b040afbc0b08da5f6ab967%7C5571c7d4286b47f69d
> +d50aa688773c8e%7C0%7C0%7C637927209230510374%7CUnknown%7CTWFpbGZsb3d8e
> +yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> +000%7C%7C%7C&amp;sdata=H6KQQcoI5KkzhPHKMtMatHOq84biBwLpHY%2F7FSa7wPc%
> +3D&amp;reserved=0
> +$schema: 
> +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cjimmy.che
> +n%40moxa.com%7Cb1a7593190b040afbc0b08da5f6ab967%7C5571c7d4286b47f69dd
> +50aa688773c8e%7C0%7C0%7C637927209230510374%7CUnknown%7CTWFpbGZsb3d8ey
> +JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> +00%7C%7C%7C&amp;sdata=qGexv3EptWO61X2o%2BcY0Clle2qHlEGFDcksMR1A4GWw%3
> +D&amp;reserved=0
> +
> +title: MOXA platform device tree bindings
> +
> +maintainers:
> +  - Jimmy Chen <jimmy.chen@moxa.com>
> +
> +properties:
> +  compatible:
> +    description: UC-82XX-LX embedded computer
> +    items:
> +      - const: moxa,uc-8210
> +      - const: moxa,uc-8220
> +
> +additionalProperties: true
> +...
> +
> --
> 2.20.1
>