Re: [PATCH 1/2] hwmon: (pmbus/max20754) Add support for MAX20754

[kernel test robot <lkp@intel.com>]

Hi Atif,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Atif-Ofluoglu/Adding-MAX20754-support/20220707-233249
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: arc-randconfig-r043-20220707 (https://download.01.org/0day-ci/archive/20220708/202207080255.fBmFH9Ry-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/52ef0855bc74f95cd6c170b5475a3e957d7e1028
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Atif-Ofluoglu/Adding-MAX20754-support/20220707-233249
        git checkout 52ef0855bc74f95cd6c170b5475a3e957d7e1028
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/hwmon/pmbus/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/hwmon/pmbus/max20754.c:381:19: error: 'pmbus_do_remove' undeclared here (not in a function); did you mean 'pmbus_do_probe'?
     381 |         .remove = pmbus_do_remove,
         |                   ^~~~~~~~~~~~~~~
         |                   pmbus_do_probe


vim +381 drivers/hwmon/pmbus/max20754.c

   375	
   376	static struct i2c_driver max20754_driver = {
   377		.driver = {
   378			   .name = "max20754",
   379			   },
   380		.probe_new = max20754_probe,
 > 381		.remove = pmbus_do_remove,
   382		.id_table = max20754_id,
   383	};
   384	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp