From: Andre Przywara <andre.przywara@arm.com>
To: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: [PATCH v13 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional
Date: Fri, 8 Jul 2022 11:52:30 +0100 [thread overview]
Message-ID: <20220708105235.3983266-3-andre.przywara@arm.com> (raw)
In-Reply-To: <20220708105235.3983266-1-andre.przywara@arm.com>
The R_PIO pinctrl device on the Allwinner H616 SoC does not have an
interrupt (it features only two pins).
However the binding requires at least naming one upstream interrupt,
plus the #interrupt-cells and interrupt-controller properties.
Drop the unconditional requirement for the interrupt properties, and
make them dependent on being not this particular pinctrl device.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Samuel Holland <samuel@sholland.org>
---
.../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
index bfce850c20351..360dcd757e9da 100644
--- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
@@ -133,14 +133,11 @@ patternProperties:
required:
- "#gpio-cells"
- - "#interrupt-cells"
- compatible
- reg
- - interrupts
- clocks
- clock-names
- gpio-controller
- - interrupt-controller
allOf:
# FIXME: We should have the pin bank supplies here, but not a lot of
@@ -148,6 +145,19 @@ allOf:
# warnings.
- $ref: "pinctrl.yaml#"
+ - if:
+ not:
+ properties:
+ compatible:
+ enum:
+ - allwinner,sun50i-h616-r-pinctrl
+
+ then:
+ required:
+ - "#interrupt-cells"
+ - interrupts
+ - interrupt-controller
+
- if:
properties:
compatible:
--
2.25.1
next prev parent reply other threads:[~2022-07-08 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 10:52 [PATCH v13 0/7] arm64: sunxi: Allwinner H616 SoC DT support Andre Przywara
2022-07-08 10:52 ` [PATCH v13 1/7] dt-bindings: arm: sunxi: Add H616 EMAC compatible Andre Przywara
2022-07-09 16:19 ` Samuel Holland
2022-07-08 10:52 ` Andre Przywara [this message]
2022-07-08 10:52 ` [PATCH v13 3/7] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara
2022-07-09 16:19 ` Samuel Holland
2022-07-08 10:52 ` [PATCH v13 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply Andre Przywara
2022-07-08 10:52 ` [PATCH v13 5/7] dt-bindings: arm: sunxi: Add two H616 board compatible strings Andre Przywara
2022-07-08 10:52 ` [PATCH v13 6/7] arm64: dts: allwinner: h616: Add OrangePi Zero 2 board support Andre Przywara
2022-07-09 16:20 ` Samuel Holland
2022-07-08 10:52 ` [PATCH v13 7/7] arm64: dts: allwinner: h616: Add X96 Mate TV box support Andre Przywara
2022-07-09 18:13 ` [PATCH v13 0/7] arm64: sunxi: Allwinner H616 SoC DT support Jernej Škrabec
2022-07-11 8:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708105235.3983266-3-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox