From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BCAFC433EF for ; Fri, 8 Jul 2022 05:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237058AbiGHFkd (ORCPT ); Fri, 8 Jul 2022 01:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233524AbiGHFka (ORCPT ); Fri, 8 Jul 2022 01:40:30 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6387E2B7 for ; Thu, 7 Jul 2022 22:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657258829; x=1688794829; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yjIf4A78Bn+N4rkRcaIyL0vj6eL3ACMMOj7aSB3ecng=; b=HG2xbPH1sZ7w/4crkrRZEf1DTDmF5HYsdtq/dGf62Fd3uQpCxdMvaAVx wzLceeZVaL9insHLfN8zR66rNS6znz7eHLd4IkQnsaE9k0ftDyDOGa6rf /xN5Ah3bn0YkcAGWweTnqNvfgDCTIH4RbcpX6QLf1LUxoCzTToXRnp6K+ 29PiolayObqQEOxqdJ4jCtNaDSg77aXChLXZRtWxkQIyCtUvFFSk+zrX2 DdxcseGZlsbVwfIOdk6Xh3EwSRebPd8528v4VgbWbzGT3gpyBUoTYRIsJ ueOSMOeoL42VBtftzELNijgcwmwbFawvYSakWIbPXosXU+MrzQM+tN4eV Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="348180068" X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="348180068" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 22:40:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="593996400" Received: from lkp-server01.sh.intel.com (HELO 68b931ab7ac1) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2022 22:40:26 -0700 Received: from kbuild by 68b931ab7ac1 with local (Exim 4.95) (envelope-from ) id 1o9gj3-000MyI-Km; Fri, 08 Jul 2022 05:40:25 +0000 Date: Fri, 8 Jul 2022 13:39:57 +0800 From: kernel test robot To: Karthik Alapati , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Shuah Khan , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: don't use index pointer after iter Message-ID: <202207081340.OdVTd0BF-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Karthik, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.19-rc5] [also build test ERROR on linus/master] [cannot apply to staging/staging-testing next-20220707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Karthik-Alapati/staging-greybus-don-t-use-index-pointer-after-iter/20220707-183311 base: 88084a3df1672e131ddc1b4e39eeacfd39864acf config: arm-randconfig-r014-20220707 (https://download.01.org/0day-ci/archive/20220708/202207081340.OdVTd0BF-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 562c3467a6738aa89203f72fc1d1343e5baadf3c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/bc295082ef055003c6018b57d3c56c5aefcb65c5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Karthik-Alapati/staging-greybus-don-t-use-index-pointer-after-iter/20220707-183311 git checkout bc295082ef055003c6018b57d3c56c5aefcb65c5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/staging/greybus/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/staging/greybus/audio_helper.c:128:18: error: expected ';' after expression w_found = false ^ ; 1 error generated. vim +128 drivers/staging/greybus/audio_helper.c 124 125 mutex_lock(&dapm->card->dapm_mutex); 126 for (i = 0; i < num; i++) { 127 /* below logic can be optimized to identify widget pointer */ > 128 w_found = false 129 list_for_each_entry_safe(w, next_w, &dapm->card->widgets, 130 list) { 131 if (w->dapm != dapm) 132 continue; 133 if (!strcmp(w->name, widget->name)) { 134 w_found = true; 135 break; 136 } 137 w = NULL; 138 } 139 if (!w_found) { 140 dev_err(dapm->dev, "%s: widget not found\n", 141 widget->name); 142 widget++; 143 continue; 144 } 145 widget++; 146 #ifdef CONFIG_DEBUG_FS 147 if (!parent) 148 debugfs_w = debugfs_lookup(w->name, parent); 149 debugfs_remove(debugfs_w); 150 debugfs_w = NULL; 151 #endif 152 gbaudio_dapm_free_widget(w); 153 } 154 mutex_unlock(&dapm->card->dapm_mutex); 155 return 0; 156 } 157 -- 0-DAY CI Kernel Test Service https://01.org/lkp