public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, linus.walleij@linaro.org,
	kavyasree.kotagiri@microchip.com, alexandre.belloni@bootlin.com,
	colin.foster@in-advantage.com, UNGLinuxDriver@microchip.com,
	maxime.chevallier@bootlin.com,
	Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH 2/2] pinctrl: ocelot: Fix pincfg
Date: Fri, 8 Jul 2022 14:21:14 +0800	[thread overview]
Message-ID: <202207081432.wshyILwP-lkp@intel.com> (raw)
In-Reply-To: <20220707185342.2697569-3-horatiu.vultur@microchip.com>

Hi Horatiu,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Horatiu-Vultur/pinctrl-ocelot-Add-fixes-for-ocelot-driver/20220708-025029
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220708/202207081432.wshyILwP-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/pinctrl/pinctrl-ocelot.c:1954 ocelot_pinctrl_create_pincfg() warn: inconsistent indenting

vim +1954 drivers/pinctrl/pinctrl-ocelot.c

ce8dc0943357a5 Alexandre Belloni 2018-01-06  1949  
076d9e71bcf8a8 Colin Foster      2021-11-19  1950  static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
076d9e71bcf8a8 Colin Foster      2021-11-19  1951  {
076d9e71bcf8a8 Colin Foster      2021-11-19  1952  	void __iomem *base;
076d9e71bcf8a8 Colin Foster      2021-11-19  1953  
94ef32970d4076 Michael Walle     2022-02-16 @1954  		base = devm_platform_ioremap_resource(pdev, 1);
076d9e71bcf8a8 Colin Foster      2021-11-19  1955  	if (IS_ERR(base)) {
076d9e71bcf8a8 Colin Foster      2021-11-19  1956  		dev_dbg(&pdev->dev, "Failed to ioremap config registers (no extended pinconf)\n");
076d9e71bcf8a8 Colin Foster      2021-11-19  1957  		return NULL;
076d9e71bcf8a8 Colin Foster      2021-11-19  1958  	}
076d9e71bcf8a8 Colin Foster      2021-11-19  1959  
162d70439a9da8 Horatiu Vultur    2022-07-07  1960  	return devm_regmap_init_mmio(&pdev->dev, base, &regmap_pincfg);
076d9e71bcf8a8 Colin Foster      2021-11-19  1961  }
076d9e71bcf8a8 Colin Foster      2021-11-19  1962  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

      parent reply	other threads:[~2022-07-08  6:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 18:53 [PATCH 0/2] pinctrl: ocelot: Add fixes for ocelot driver Horatiu Vultur
2022-07-07 18:53 ` [PATCH 1/2] pinctrl: ocelot: Fix pincfg for lan966x Horatiu Vultur
2022-07-08  8:27   ` Michael Walle
2022-07-08 19:45     ` Horatiu Vultur
2022-07-07 18:53 ` [PATCH 2/2] pinctrl: ocelot: Fix pincfg Horatiu Vultur
2022-07-08  0:31   ` Colin Foster
2022-07-08 19:41     ` Horatiu Vultur
2022-07-08  2:05   ` kernel test robot
2022-07-08  6:21   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202207081432.wshyILwP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=colin.foster@in-advantage.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kavyasree.kotagiri@microchip.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox