From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7433EC433EF for ; Fri, 8 Jul 2022 17:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238725AbiGHRCE (ORCPT ); Fri, 8 Jul 2022 13:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238620AbiGHRB6 (ORCPT ); Fri, 8 Jul 2022 13:01:58 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A05F1F2C1 for ; Fri, 8 Jul 2022 10:01:58 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id n10so6051450wrc.4 for ; Fri, 08 Jul 2022 10:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L2Td8oL+DP/Q1s4zsf07k4XdXJJCRjGdcs4j+JMi+M0=; b=E4fegH8AA6z2N2S142RPFIDcT4aTf/9A25WCIatRlLcZioJSoRoOlQTCR9qI+Vk62g 08VAESHPLztMQcIk9J61xc5w52quQfl6oDXtVeuX6rI+VHEuGXB1SzW4bSJRbRwYL7uQ UxonLNF7qKW9X0Trlngp7sexV5ZNCeSTVVR2EbdK+kDDW+xu+jYI0+ZIMr6GgnFt3+II G2+HVNa4CveJpuCZ8b777PuLjubxIwTcmqNNpBgKqdU+9qQ5/e2I+UUI4NI4JHV/2Cp0 ArgmbAk6vc+h20kp9yc6wcASYMiF6QU7LbhFt63vIVRI9oo/1P8Y4HWDj/aZqMeXq5+v oUVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L2Td8oL+DP/Q1s4zsf07k4XdXJJCRjGdcs4j+JMi+M0=; b=wkD+PnoJq2A9FlK34i7QmjmzDnXHLMrD2NpyRbL5SuMNV0U/lLCXM9dRz9JybnstbJ y6WnP6yKas4owpqn3q1YFeOmBQN0j3lytvySGvMoTrFvN/mSCIXfnFCVHGPxCnwwEOzo sP8UIYPjd6Jr2XfwG5Nz/t5cHkG/oKHkZGqPDyKqwOWVj8ambCFljVcIoAJYnSuse2RV NnbWFTs2EBzd76BepD/04wk89HXymnz+NNvlzI4MdgJbW901ssZs/eITNP4K58KhwH77 lyJcBTplUSpwGwEVlTonrn0pqKOIaio/q2ws+o6VgFFwH55yPGjSB9yzPaKXHNGfg/jU lq0A== X-Gm-Message-State: AJIora+/RMBYW61WhjsYW4VyD2BDmREcgsaZ1AdSmDJTGs33FVXK8wlW qzW7GMp2qfaqQvpPzm2PuHtPp9+vDN1jl5KD X-Google-Smtp-Source: AGRyM1u7by1zvcxm/P8FP14CKaCIB4lENgo23/wSKJKIonXN7rCuigAijPwL78UQKKChlPANOgLSAQ== X-Received: by 2002:a5d:6d06:0:b0:21b:c434:d99e with SMTP id e6-20020a5d6d06000000b0021bc434d99emr4056270wrq.148.1657299716615; Fri, 08 Jul 2022 10:01:56 -0700 (PDT) Received: from rainbowdash.office.codethink.co.uk ([167.98.27.226]) by smtp.gmail.com with ESMTPSA id t5-20020adfe105000000b002103bd9c5acsm41336252wrz.105.2022.07.08.10.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 10:01:56 -0700 (PDT) From: Ben Dooks To: dmaengine@vger.kernel.org, Eugeniy.Paltsev@synopsys.com Cc: linux-kernel@vger.kernel.org, vkoul@kernel.org, Sudip Mukherjee , Jude Onyenegecha , Ben Dooks Subject: [PATCH 2/3] dmaengine: dw-axi-dmac: do not print NULL LLI during error Date: Fri, 8 Jul 2022 18:01:52 +0100 Message-Id: <20220708170153.269991-3-ben.dooks@sifive.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220708170153.269991-1-ben.dooks@sifive.com> References: <20220708170153.269991-1-ben.dooks@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During debugging we have seen an issue where axi_chan_dump_lli() is passed a NULL LLI pointer which ends up causing an OOPS due to trying to get fields from it. Simply print NULL LLI and exit to avoid this. Signed-off-by: Ben Dooks --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 75c537153e92..d6ef5f49f281 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1008,6 +1008,11 @@ static void axi_chan_dump_regs(struct axi_dma_chan *chan) static void axi_chan_dump_lli(struct axi_dma_chan *chan, struct axi_dma_hw_desc *desc) { + if (!desc->lli) { + dev_err(dchan2dev(&chan->vc.chan), "NULL LLI\n"); + return; + } + dev_err(dchan2dev(&chan->vc.chan), "SAR: 0x%llx DAR: 0x%llx LLP: 0x%llx BTS 0x%x CTL: 0x%x:%08x", le64_to_cpu(desc->lli->sar), -- 2.35.1