Re: [PATCH v4 1/2] sched/rt: fix bad task migration for rt tasks

Schspa Shi
2022-07-12T01:35:26Z

Steven Rostedt <rostedt@goodmis.org> writes:

> On Tue, 12 Jul 2022 08:53:56 +0800
> Schspa Shi <schspa@gmail.com> wrote:
>
>> How about to change this to
>>
>> /*
>> * We had to unlock the run queue. In
>> * the mean time, task could have
>> * migrated already or had its affinity changed.
>> * Also make sure that it wasn't scheduled on its rq.
>> * It is possible the task was scheduled, set
>> * "migrate_disabled" and then got preempted, And we
>> * check task migration disable flag here too.
>> */
>
> That's better. But of course it needs better formatting ;-)
>
> -- Steve

I have upload a v5 patch for this comment change, please review it. ;-)
Link: https://lore.kernel.org/all/20220712013125.623338-1-schspa@gmail.com/T/#t

--
BRs
Schspa Shi