From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 5/7] platform/x86: serial-multi-instantiate: Use while (i--) pattern to clean up
Date: Sat, 9 Jul 2022 03:06:34 +0300 [thread overview]
Message-ID: <20220709000636.35550-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20220709000636.35550-1-andriy.shevchenko@linux.intel.com>
Use more natural while (i--) patter to clean up allocated resources.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/serial-multi-instantiate.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
index 520236b11b2c..38bc644a50c3 100644
--- a/drivers/platform/x86/serial-multi-instantiate.c
+++ b/drivers/platform/x86/serial-multi-instantiate.c
@@ -70,11 +70,11 @@ static int smi_get_irq(struct platform_device *pdev, struct acpi_device *adev,
static void smi_devs_unregister(struct smi *smi)
{
- while (smi->i2c_num > 0)
- i2c_unregister_device(smi->i2c_devs[--smi->i2c_num]);
+ while (smi->i2c_num--)
+ i2c_unregister_device(smi->i2c_devs[smi->i2c_num]);
- while (smi->spi_num > 0)
- spi_unregister_device(smi->spi_devs[--smi->spi_num]);
+ while (smi->spi_num--)
+ spi_unregister_device(smi->spi_devs[smi->spi_num]);
}
/**
--
2.35.1
next prev parent reply other threads:[~2022-07-09 0:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 0:06 [PATCH v1 1/7] platform/x86: serial-multi-instantiate: return -ENOENT when no resources found Andy Shevchenko
2022-07-09 0:06 ` [PATCH v1 2/7] platform/x86: serial-multi-instantiate: Improve autodetection Andy Shevchenko
2022-07-09 9:47 ` Hans de Goede
[not found] ` <CAHp75VfVoTcZD7vXxXckxu-crsXr7m4bx8F9D9cs2TtBbyeYqQ@mail.gmail.com>
2022-07-09 11:00 ` Hans de Goede
2022-07-09 11:34 ` Andy Shevchenko
2022-07-09 14:46 ` Hans de Goede
2022-07-09 9:48 ` Hans de Goede
2022-07-09 0:06 ` [PATCH v1 3/7] platform/x86: serial-multi-instantiate: Drop duplicate check Andy Shevchenko
2022-07-09 9:50 ` Hans de Goede
2022-07-09 0:06 ` [PATCH v1 4/7] platform/x86: serial-multi-instantiate: Improve dev_err_probe() messaging Andy Shevchenko
2022-07-09 0:06 ` Andy Shevchenko [this message]
2022-07-09 0:06 ` [PATCH v1 6/7] platform/x86: serial-multi-instantiate: Get rid of redundant 'else' Andy Shevchenko
2022-07-09 0:06 ` [PATCH v1 7/7] platform/x86: serial-multi-instantiate: Sort ACPI IDs by HID Andy Shevchenko
2022-07-09 9:45 ` [PATCH v1 1/7] platform/x86: serial-multi-instantiate: return -ENOENT when no resources found Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220709000636.35550-5-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox