Re: [PATCH] arm64: dts: qcom: sc8280xp: Add lost ranges for timer

Johan Hovold
2022-07-13T05:58:28Z

On Tue, Jul 12, 2022 at 08:53:34PM -0500, Bjorn Andersson wrote:
> On Tue 12 Jul 09:53 CDT 2022, Johan Hovold wrote:
> > On Mon, Jul 11, 2022 at 07:28:26PM -0700, Bjorn Andersson wrote:
> > > On Mon 11 Jul 01:56 PDT 2022, Johan Hovold wrote:

> > > > While addressing the current issue, this looks odd to me. Why not use a
> > > > non-zero parent bus address here instead?
> > > >
> > >
> > > I guess we could express the frames relative the timer range, but that
> > > would imply that anyone porting downstream dts snippets would have to
> > > translate these addresses - or more likely would end up just copying the
> > > existing cases.
> > >
> > > > And please use hex notation consistently for the addresses.
> > >
> > > That seems like a reasonable ask, I can fix that up. But on both
> > > accounts this matches what I merged for all the other platforms in:
> > >
> > > 458ebdbb8e5d ("arm64: dts: qcom: timer should use only 32-bit size")
> > >
> > >
> > > So I guess we'll also need to go back and fix up the style of all the
> > > other platforms - just because we're not allowed to express the frames
> > > in 64-bits according to the binding...
> >
> > Would have been easier to just amend the binding. I don't think that
> > #size-cells = 1 constraint is set in stone as it was added when
> > converting to DT schema.
>
> Rob disagrees with this idea:
> https://lore.kernel.org/all/CAL_JsqJMMCBnukFZLJ8X14s1PwqT=VEwKjDVj8mm4h55pZpcuw@mail.gmail.com/

Ok, thanks for the link. I'd still prefer a non-zero parent-bus address
in that ranges, but we can change that later too.

> > But you probably should amend the commit message and mention that this
> > fixes time keeping. I had recently noticed that something was off
> > (journals rotating, and erratic cursor blinking) but didn't realise that
> > timers were broken until you posted this.
> >
>
> That sounds like a good idea, thanks for the suggestion.

I guess you're posting a v2, but otherwise feel free to add my

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

when applying.

Johan