Re: [PATCH 01/10] dt-bindings: PCI: qcom: Fix reset conditional

Dmitry Baryshkov
2022-06-29T14:37:42Z

On 29 June 2022 17:09:51 GMT+03:00, Johan Hovold <johan+linaro@kernel.org> wrote:
>Fix the reset conditional which always evaluated to true due to a
>misspelled property name ("compatibles" in plural).
>
>Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms")
>Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>---
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>index 7e84063afe25..ed9f9462a758 100644
>--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>@@ -615,7 +615,7 @@ allOf:
> - if:
> not:
> properties:
>- compatibles:
>+ compatible:

Argh. Thanks for noticing and fixing the typo.
If necessary I can respin MSI series in a few days.

Anyway, for this patch:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> contains:
> enum:
> - qcom,pcie-msm8996

--
With best wishes
Dmitry