Re: [PATCH 04/10] dt-bindings: PCI: qcom: Add SC8280XP to binding

Johan Hovold
2022-07-01T08:41:22Z

On Fri, Jul 01, 2022 at 10:37:55AM +0200, Krzysztof Kozlowski wrote:
> On 29/06/2022 16:09, Johan Hovold wrote:
> > Add the SC8280XP platform to the binding.
> >
> > SC8280XP use four host interrupts for MSI routing so remove the obsolete
> > comment referring to newer chipsets supporting one or eight interrupts
> > (e.g. for backwards compatibility).
> >
>
> (...)
>
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - qcom,pcie-sc8280xp
> > + then:
> > + properties:
> > + interrupts:
> > + minItems: 4
> > + maxItems: 4
> > + interrupt-names:
> > + items:
> > + - const: msi0
> > + - const: msi1
> > + - const: msi2
> > + - const: msi3
>
> What the previous #3 commit is missing is:
> "This allows for adding further platforms with for example four MSI
> interrupts, without resorting to nested conditionals."

Yeah, that would make the comment more self-contained. I'll amend it if
I need to respin.

Johan