Re: [PATCH 09/10] PCI: qcom: Clean up IP configurations

Rob Herring
2022-07-01T18:36:01Z

On Wed, Jun 29, 2022 at 04:09:59PM +0200, Johan Hovold wrote:
> The various IP versions have different configurations that are encoded
> in separate sets of operation callbacks. Currently, there is no need for
> also maintaining corresponding sets of data parameters, but it is
> conceivable that these may again be found useful (e.g. to implement
> minor variations of the operation callbacks).
>
> Rename the default configuration structures after the IP version they
> apply to so that they can more easily be reused by different SoCs.
>
> Note that SoC specific configurations can be added later if need arises
> (e.g. cfg_sc8280xp).
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/pci/controller/dwc/pcie-qcom.c | 85 ++++++++------------------
> 1 file changed, 27 insertions(+), 58 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>