* [PATCH] staging: qlge: Fix indentation issue under long for loop
@ 2022-07-10 2:16 Binyi Han
2022-07-10 2:23 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Binyi Han @ 2022-07-10 2:16 UTC (permalink / raw)
To: Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu, Greg Kroah-Hartman
Cc: netdev, linux-staging, linux-kernel
Fix indentation issue to adhere to Linux kernel coding style.
Issue found by checkpatch.
Signed-off-by: Binyi Han <dantengknight@gmail.com>
---
drivers/staging/qlge/qlge_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 1a378330d775..60c796a64135 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3009,8 +3009,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
for (page_entries = 0; page_entries <
MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
- base_indirect_ptr[page_entries] =
- cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
+ base_indirect_ptr[page_entries] =
+ cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma);
cqicb->lbq_buf_size =
cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size));
@@ -3024,8 +3024,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
for (page_entries = 0; page_entries <
MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
- base_indirect_ptr[page_entries] =
- cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
+ base_indirect_ptr[page_entries] =
+ cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
cqicb->sbq_addr =
cpu_to_le64(rx_ring->sbq.base_indirect_dma);
cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: qlge: Fix indentation issue under long for loop
2022-07-10 2:16 [PATCH] staging: qlge: Fix indentation issue under long for loop Binyi Han
@ 2022-07-10 2:23 ` Joe Perches
2022-07-10 8:27 ` binyi
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2022-07-10 2:23 UTC (permalink / raw)
To: Binyi Han, Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu,
Greg Kroah-Hartman
Cc: netdev, linux-staging, linux-kernel
On Sat, 2022-07-09 at 19:16 -0700, Binyi Han wrote:
> Fix indentation issue to adhere to Linux kernel coding style.
> Issue found by checkpatch.
>
> Signed-off-by: Binyi Han <dantengknight@gmail.com>
> ---
> drivers/staging/qlge/qlge_main.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
[]
> @@ -3009,8 +3009,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
>
> for (page_entries = 0; page_entries <
> MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
Probably better to change the for loop to 3 lines as well.
for (page_entries = 0;
page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
page_entries++)
> @@ -3024,8 +3024,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
>
> for (page_entries = 0; page_entries <
> MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> - base_indirect_ptr[page_entries] =
> - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> + base_indirect_ptr[page_entries] =
> + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
etc...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: qlge: Fix indentation issue under long for loop
2022-07-10 2:23 ` Joe Perches
@ 2022-07-10 8:27 ` binyi
0 siblings, 0 replies; 3+ messages in thread
From: binyi @ 2022-07-10 8:27 UTC (permalink / raw)
To: Joe Perches
Cc: Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu, Greg Kroah-Hartman,
netdev, linux-staging, linux-kernel
On Sat, Jul 09, 2022 at 07:23:20PM -0700, Joe Perches wrote:
> On Sat, 2022-07-09 at 19:16 -0700, Binyi Han wrote:
> > Fix indentation issue to adhere to Linux kernel coding style.
> > Issue found by checkpatch.
> >
> > Signed-off-by: Binyi Han <dantengknight@gmail.com>
> > ---
> > drivers/staging/qlge/qlge_main.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> []
> > @@ -3009,8 +3009,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> >
> > for (page_entries = 0; page_entries <
> > MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
>
> Probably better to change the for loop to 3 lines as well.
>
> for (page_entries = 0;
> page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> page_entries++)
>
> > @@ -3024,8 +3024,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> >
> > for (page_entries = 0; page_entries <
> > MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> > - base_indirect_ptr[page_entries] =
> > - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> > + base_indirect_ptr[page_entries] =
> > + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
>
> etc...
>
Thanks for the suggestion. Will send a patch v2 in another thread.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-10 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-10 2:16 [PATCH] staging: qlge: Fix indentation issue under long for loop Binyi Han
2022-07-10 2:23 ` Joe Perches
2022-07-10 8:27 ` binyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox