Re: [PATCH v2] x86/mm/tlb: ignore f->new_tlb_gen when zero

Hugh Dickins
2022-07-13T00:50:02Z

On Wed, 13 Jul 2022, Nadav Amit wrote:
> On Jul 11, 2022, at 10:39 AM, Nadav Amit <namit@vmware.com> wrote:
> > On Jul 10, 2022, at 4:28 PM, Nadav Amit <nadav.amit@gmail.com> wrote:
> >> From: Nadav Amit <namit@vmware.com>
> >>
> >> Commit aa44284960d5 ("x86/mm/tlb: Avoid reading mm_tlb_gen when
> >> possible") introduced an optimization of skipping the flush if the TLB
> >> generation that is flushed (as provided in flush_tlb_info) was already
> >> flushed.
> >
> > Dave,
> >
> > Can you please review this patch today?
> >
> > I feel bad (for a good reason) for breaking swap/migration.
> >
> > Thanks,
> > Nadav
>
> Ping?
>
> As you know, this really must go into 5.19 or otherwise aa44284960d5
> reverted.

No, aa44284960d5 is not in 5.19-rc: it's in linux-next heading for 5.20.

Hugh