From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Ben Dooks <ben.dooks@sifive.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
iommu@lists.linux-foundation.org, Christoph Hellwig <hch@lst.de>,
Sudip Mukherjee <sudip.mukherjee@sifive.com>,
Jude Onyenegecha <jude.onyenegecha@sifive.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] swiotlb: ensure io_tlb_default_mem spinlock always initialised
Date: Mon, 11 Jul 2022 12:21:34 +0200 [thread overview]
Message-ID: <20220711102134.GB4639@lst.de> (raw)
In-Reply-To: <e6c43ef0-870b-5fe6-141e-0a3d566b030e@arm.com>
On Mon, Jul 11, 2022 at 11:07:17AM +0100, Robin Murphy wrote:
> If none of your peripherals should need SWIOTLB, then the fact that
> you're ending up in swiotlb_map() at all is a clear sign that
> something's wrong. Most likely someone's forgotten to set their DMA
> masks correctly.
Yes.
>
> However, by inspection it seems we do have a bug here as well, for which
> the correct fix should be as below. The fireworks you're *supposed* to
> get in that situation are considerably louder and more obvious than a
> DEBUG_SPINLOCK complaint ;)
This looks sensible, I'll pick it up.
next prev parent reply other threads:[~2022-07-11 11:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 17:08 [PATCH] swiotlb: ensure io_tlb_default_mem spinlock always initialised Ben Dooks
2022-07-08 20:32 ` Robin Murphy
2022-07-11 7:26 ` Ben Dooks
2022-07-11 10:07 ` Robin Murphy
2022-07-11 10:21 ` Christoph Hellwig [this message]
2022-07-11 10:24 ` Ben Dooks
2022-07-11 10:39 ` Christoph Hellwig
2022-07-11 10:42 ` Ben Dooks
2022-07-11 11:01 ` Robin Murphy
2022-07-11 11:52 ` Conor.Dooley
2022-07-11 12:45 ` Ben Dooks
2022-07-11 12:56 ` Conor.Dooley
2022-07-11 12:54 ` Ben Dooks
2022-07-11 13:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711102134.GB4639@lst.de \
--to=hch@lst.de \
--cc=ben.dooks@sifive.com \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=jude.onyenegecha@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sudip.mukherjee@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox