Re: [PATCH V4 3/9] dt-bindings: PCI: tegra234: Add schema for tegra234 endpoint mode

Vidya Sagar
2022-07-09T02:34:10Z

On 7/7/2022 5:57 PM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Thu, 07 Jul 2022 13:42:55 +0530, Vidya Sagar wrote:
>> Add support for PCIe controllers that operate in the endpoint mode
>> in tegra234 chipset.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> V4:
>> * Rebased on top of previous patch
>>
>> V3:
>> * New patch in this series
>>
>> .../bindings/pci/nvidia,tegra194-pcie-ep.yaml | 123 +++++++++++++++++-
>> 1 file changed, 117 insertions(+), 6 deletions(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.example.dtb: pcie-ep@141a0000: Unevaluated properties are not allowed ('nvidia,enable-ext-refclk' was unexpected)
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.

I did run 'make dt_binding_check' before sending the patches for review
and didn't observe any issue. Just to make sure that I observe the same
issue locally, I updated dtschema and gave DT_CHECKER_FLAGS=-m and yet
didn't observe the tool reporting any issue.
FWIW, I think I missed adding the documentation for
'nvidia,enable-ext-refclk' property. I'll add it and send again, but
before that, I would like to see if my change addresses the issue
correctly and also there are no other issues. Could you please help me
with why I'm not observing the issue locally?

FWIW, Here is the output I get with V4 patch.

vidya@vidya-virtual-machine:~/x/linux-next$ make DT_CHECKER_FLAGS=-m
dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml

LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
/home/vidya/x/linux-next/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-sor.yaml:
ignoring, error in schema: allOf: 1: if: not: properties
DTEX
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.example.dts
DTC
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.example.dtb
CHECK
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.example.dtb
vidya@vidya-virtual-machine:~/x/linux-next$

Thanks,
Vidya Sagar

>