Re: [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

CK Hu
2022-07-13T08:30:21Z

Hi, Bo-Chen:

On Tue, 2022-07-12 at 19:12 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This patch adds a embedded displayport driver for the MediaTek mt8195
> SoC.
>
> It supports the MT8195, the embedded DisplayPort units. It offers
> DisplayPort 1.4 with up to 4 lanes.
>
> The driver creates a child device for the phy. The child device will
> never exist without the parent being active. As they are sharing a
> register range, the parent passes a regmap pointer to the child so
> that
> both can work with the same register range. The phy driver sets
> device
> data that is read by the parent to get the phy device that can be
> used
> to control the phy properties.
>
> This driver is based on an initial version by
> Jitao shi <jitao.shi@mediatek.com>
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---

[snip]

> +
> +static int mtk_dp_set_color_depth(struct mtk_dp *mtk_dp)
> +{
> + /* Only support 8 bits currently */
> + mtk_dp->info.depth = DP_MSA_MISC_8_BPC;

Only support DP_MSA_MISC_8_BPC, so it's not necessary use a variable to
store this information. Drop depth.

Regards,
CK

> +
> + /* Update MISC0 */
> + mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_3034,
> + DP_MSA_MISC_8_BPC, DP_TEST_BIT_DEPTH_MASK);
> +
> + mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_303C,
> + VIDEO_COLOR_DEPTH_DP_ENC0_P0_8BIT,
> + VIDEO_COLOR_DEPTH_DP_ENC0_P0_MASK);
> + return 0;
> +}
> +