Re: [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

Rex-BC Chen
2022-07-14T08:24:41Z

On Wed, 2022-07-13 at 16:10 +0800, CK Hu wrote:
> Hi, Bo-Chen:
>
> On Tue, 2022-07-12 at 19:12 +0800, Bo-Chen Chen wrote:
> > From: Markus Schneider-Pargmann <msp@baylibre.com>
> >
> > This patch adds a embedded displayport driver for the MediaTek
> > mt8195
> > SoC.
> >
> > It supports the MT8195, the embedded DisplayPort units. It offers
> > DisplayPort 1.4 with up to 4 lanes.
> >
> > The driver creates a child device for the phy. The child device
> > will
> > never exist without the parent being active. As they are sharing a
> > register range, the parent passes a regmap pointer to the child so
> > that
> > both can work with the same register range. The phy driver sets
> > device
> > data that is read by the parent to get the phy device that can be
> > used
> > to control the phy properties.
> >
> > This driver is based on an initial version by
> > Jitao shi <jitao.shi@mediatek.com>
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > ---
>
> [snip]
>
> > +
> > +struct mtk_dp_timings {
> > + struct videomode vm;
> > +};
> > +
> > +struct mtk_dp_irq_sta {
> > + bool hpd_inerrupt;
> > +};
> > +
> > +struct mtk_dp_train_info {
> > + bool tps3;
> > + bool tps4;
> > + bool sink_ssc;
> > + bool cable_plugged_in;
> > + bool cable_state_change;
> > + bool cr_done;
> > + bool eq_done;
> > + /* link_rate is in multiple of 0.27Gbps */
> > + int link_rate;
> > + int lane_count;
> > + struct mtk_dp_irq_sta irq_sta;
>
> There is only one member in struct mtk_dp_irq_sta, so drop struct
> mtk_dp_irq_sta and use bool hpd_inerrupt directly here.
>

Hello CK,

ok, I will drop this.

> > +};
> > +
> > +struct mtk_dp_info {
> > + u32 depth;
> > + enum dp_pixelformat format;
> > + struct mtk_dp_timings timings;
>
> There is only one member in struct mtk_dp_timings, so drop struct
> mtk_dp_timings and use struct videomode vm directly here.
>

This structure will add more variable in following patch.
whole struct is like,
struct mtk_dp_timings {
struct videomode vm;
u8 frame_rate;
u32 pix_rate_khz;
};

I want to keep this.

BRs,
Bo-Chen

> Regards,
> CK
>
> > +};
> > +
>
>