From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83289C43334 for ; Tue, 12 Jul 2022 15:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbiGLPMm (ORCPT ); Tue, 12 Jul 2022 11:12:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233524AbiGLPMV (ORCPT ); Tue, 12 Jul 2022 11:12:21 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F23BECF6DC for ; Tue, 12 Jul 2022 08:05:30 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id l12so7459740plk.13 for ; Tue, 12 Jul 2022 08:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XVcR527JhdZvBKlBjULUnVYqMzSRXSuEqCz9Q7B5TNI=; b=Mv3pCNYCKJGOs+12tew/uvkGUIp3FtvrEFt54UFFfXavTpcQqwzEITlYjd07kHMPcn TQqV88YKIrJ+XYIJQ0PV7UOWA6N6GH27kLlmk+GGTWcaWdea6i+KOIvU5MT1rbW+677B Bch0F51lwAU5iYekiHIWifBqaQrFD29q5Yj6hv5DZc5sB32YWH5z3sP5B2FCNLs3dndG Of24R+XNV7Ib/uB61O4XRA91Il+T6pECQisnlj2UF0Vm1eggTV8YHg6QANtZiQEcl9zK HVhd6F4BItnxJVGa8pl1YNz4toQ5WjtIcOJ+efpiOML8gBGpC9e/QxW1M+W/jeb6aONf Bzag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XVcR527JhdZvBKlBjULUnVYqMzSRXSuEqCz9Q7B5TNI=; b=kX5exaw/dbSEl05JTOBmYSpyzxP8syP9vuXnd3Wtn9Ax51hM8rriIyEU6A7QEyRiQf rchs/jZWGOK/ATB24V+sb78JeoWCTXRR8iyWEv1Y2SlC5JiC+l606DLuE4zv37g9fvHV YZ56muaqKjuYuzbNqoVaLSWEr6a7GoQb+yvMBBBCYFairMXHV9tC8DVU4X2S7IxQXhCx yhWMO2GVnHqLt7x9/mFrwueDw8dRWvA4SkTqpY1may0Mkj43oOkRxqjhdyc5SrH4Y7Ya +wIh50uqahmzeUrk4EI3W8Jzo2NHHDRHN9F4Mpwpt/2s3RHuGz79YIM1MURmoc0texe7 d8pA== X-Gm-Message-State: AJIora9Fraf9hAKjv1dT6SUxVJha2+XjmFi8WuRlmC3NDa1VpJ/lK3h+ 1MlePKaGc9yd4KNLbWQFLy4= X-Google-Smtp-Source: AGRyM1tS8TfOtiRWrtrX1tWkbYYA1LflOerM9l7xeLcnh8TRBBZYIQvmK4Zn2YQZ4e+W67hGitmB2g== X-Received: by 2002:a17:902:f381:b0:16b:d6e0:bfeb with SMTP id f1-20020a170902f38100b0016bd6e0bfebmr25222991ple.66.1657638329991; Tue, 12 Jul 2022 08:05:29 -0700 (PDT) Received: from localhost.localdomain (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with ESMTPSA id h7-20020a170902f54700b0016be4d310b2sm7002737plf.80.2022.07.12.08.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 08:05:29 -0700 (PDT) From: Schspa Shi To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, zhaohui.shi@horizon.ai, Schspa Shi Subject: [PATCH v6 1/2] sched/rt: fix bad task migration for rt tasks Date: Tue, 12 Jul 2022 23:05:05 +0800 Message-Id: <20220712150506.632304-1-schspa@gmail.com> X-Mailer: git-send-email 2.37.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 95158a89dd50 ("sched,rt: Use the full cpumask for balancing") allow find_lock_lowest_rq to pick a task with migration disabled. This commit is intended to push the current running task on this CPU away. There is a race scenarios, which allows a migration disabled task to be migrated to another CPU. When there is a RT task with higher priority, rt sched class was intended to migrate higher priority task to lowest rq via push_rt_tasks, this BUG will happen here. With the system running on PREEMPT_RT, rt_spin_lock will disable migration, this will make the problem easier to reproduce. I have seen this crash on PREEMPT_RT, from the logs, there is a race when trying to migrate higher priority tasks to the lowest rq. Please refer to the following scenarios. CPU0 CPU1 ------------------------------------------------------------------ push_rt_task check is_migration_disabled(next_task) task not running and migration_disabled == 0 find_lock_lowest_rq(next_task, rq); _double_lock_balance(this_rq, busiest); raw_spin_rq_unlock(this_rq); double_rq_lock(this_rq, busiest); <> task become running migrate_disable(); deactivate_task(rq, next_task, 0); set_task_cpu(next_task, lowest_rq->cpu); WARN_ON_ONCE(is_migration_disabled(p)); ---------OOPS------------- Crash logs as fellowing: [123671.996430] WARNING: CPU: 2 PID: 13470 at kernel/sched/core.c:2485 set_task_cpu+0x8c/0x108 [123671.996800] pstate: 20400009 (nzCv daif +PAN -UAO -TCO BTYPE=--) [123671.996811] pc : set_task_cpu+0x8c/0x108 [123671.996820] lr : set_task_cpu+0x7c/0x108 [123671.996828] sp : ffff80001268bd30 [123671.996832] pmr_save: 00000060 [123671.996835] x29: ffff80001268bd30 x28: ffff0001a3d68e80 [123671.996844] x27: ffff80001225f4a8 x26: ffff800010ab62cb [123671.996854] x25: ffff80026d95e000 x24: 0000000000000005 [123671.996864] x23: ffff00019746c1b0 x22: 0000000000000000 [123671.996873] x21: ffff00027ee33a80 x20: 0000000000000000 [123671.996882] x19: ffff00019746ba00 x18: 0000000000000000 [123671.996890] x17: 0000000000000000 x16: 0000000000000000 [123671.996899] x15: 000000000000000a x14: 000000000000349e [123671.996908] x13: ffff800012f4503d x12: 0000000000000001 [123671.996916] x11: 0000000000000000 x10: 0000000000000000 [123671.996925] x9 : 00000000000c0000 x8 : ffff00027ee58700 [123671.996933] x7 : ffff00027ee8da80 x6 : ffff00027ee8e580 [123671.996942] x5 : ffff00027ee8dcc0 x4 : 0000000000000005 [123671.996951] x3 : ffff00027ee8e338 x2 : 0000000000000000 [123671.996959] x1 : 00000000000000ff x0 : 0000000000000002 [123671.996969] Call trace: [123671.996975] set_task_cpu+0x8c/0x108 [123671.996984] push_rt_task.part.0+0x144/0x184 [123671.996995] push_rt_tasks+0x28/0x3c [123671.997002] task_woken_rt+0x58/0x68 [123671.997009] ttwu_do_wakeup+0x5c/0xd0 [123671.997019] ttwu_do_activate+0xc0/0xd4 [123671.997028] try_to_wake_up+0x244/0x288 [123671.997036] wake_up_process+0x18/0x24 [123671.997045] __irq_wake_thread+0x64/0x80 [123671.997056] __handle_irq_event_percpu+0x110/0x124 [123671.997064] handle_irq_event_percpu+0x50/0xac [123671.997072] handle_irq_event+0x84/0xfc To fix it, we need to check migration_disabled flag again to avoid bad migration. Fixes: 95158a89dd50 ("sched,rt: Use the full cpumask for balancing") Signed-off-by: Schspa Shi -- Changelog: v1 -> v2: - Modify commit message to add fixed commit information. - Going to retry to push the current running task on this CPU away, instead doing nothing for this migrate disabled task. v2 -> v3: - Change migration disabled check to the correct position v3 -> v4: - Check migrate disabled in find_lock_lowest_rq to avoid not necessary check when task rq is not released as Steven advised. v4 -> v5: - Adjust the comment as Steve advised to make it clear. v5 -> v6: - Adjust the comment again as Steve advised. --- kernel/sched/deadline.c | 1 + kernel/sched/rt.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index b5152961b7432..cb3b886a081c3 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2238,6 +2238,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq) !cpumask_test_cpu(later_rq->cpu, &task->cpus_mask) || task_running(rq, task) || !dl_task(task) || + is_migration_disabled(task) || !task_on_rq_queued(task))) { double_unlock_balance(rq, later_rq); later_rq = NULL; diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 8c9ed96648409..7bd3e6ecbe45e 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1998,11 +1998,15 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq) * the mean time, task could have * migrated already or had its affinity changed. * Also make sure that it wasn't scheduled on its rq. + * It is possible the task was scheduled, set + * "migrate_disabled" and then got preempted, so we must + * check the task migration disable flag here too. */ if (unlikely(task_rq(task) != rq || !cpumask_test_cpu(lowest_rq->cpu, &task->cpus_mask) || task_running(rq, task) || !rt_task(task) || + is_migration_disabled(task) || !task_on_rq_queued(task))) { double_unlock_balance(rq, lowest_rq); -- 2.37.0