From: Jakub Kicinski <kuba@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH v2,net-next] net/sched: remove return value of unregister_tcf_proto_ops
Date: Tue, 12 Jul 2022 18:09:06 -0700 [thread overview]
Message-ID: <20220712180906.07bea7f8@kernel.org> (raw)
In-Reply-To: <20220711080910.40270-1-shaozhengchao@huawei.com>
On Mon, 11 Jul 2022 16:09:10 +0800 Zhengchao Shao wrote:
> Return value of unregister_tcf_proto_ops is unused, remove it.
> -int unregister_tcf_proto_ops(struct tcf_proto_ops *ops)
> +void unregister_tcf_proto_ops(struct tcf_proto_ops *ops)
> {
> struct tcf_proto_ops *t;
> int rc = -ENOENT;
> @@ -214,7 +214,10 @@ int unregister_tcf_proto_ops(struct tcf_proto_ops *ops)
> }
> }
> write_unlock(&cls_mod_lock);
> - return rc;
> +
> + if (rc)
> + pr_warn("unregister tc filter kind(%s) failed\n", ops->kind);
I was saying WARN, by which I meant:
WARN(rc, "unregister tc filter kind(%s) failed %d\n", ops->kind, rc);
next prev parent reply other threads:[~2022-07-13 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 8:09 [PATCH v2,net-next] net/sched: remove return value of unregister_tcf_proto_ops Zhengchao Shao
2022-07-13 1:09 ` Jakub Kicinski [this message]
2022-07-13 1:45 ` 答复: " shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712180906.07bea7f8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox