Re: [PATCH v4 19/23] ata: ahci: Add DWC AHCI SATA controller support

Serge Semin
2022-06-17T20:37:19Z

On Thu, Jun 16, 2022 at 09:33:22AM +0900, Damien Le Moal wrote:
> On 2022/06/16 6:48, Serge Semin wrote:
> [...]
> >> MODULE_LICENSE("GPL v2");
> >>
> >> To match the file header SPDX.
> >
> > No. Please see the commit bf7fbeeae6db ("module: Cure the
> > MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") and what checkpatch.pl
> > says should the "GPL v2" string is used in the module license block.
> > More info regarding this macro and the possible license values are
> > described here:
> > Documentation/process/license-rules.rst
>

> ah ! OK. I was not 100% sure. Doing a quick grep, there is still a lot of (half
> ?) of "GPL v2" vs "GPL".
>
> Ignore this then.

Ok.

-Sergey

>
> >
> > -Sergey
> >
> >>
> >>> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
> >>> index 9b56490ecbc3..8f5572a9f8f1 100644
> >>> --- a/drivers/ata/ahci_platform.c
> >>> +++ b/drivers/ata/ahci_platform.c
> >>> @@ -80,9 +80,7 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_suspend,
> >>> static const struct of_device_id ahci_of_match[] = {
> >>> { .compatible = "generic-ahci", },
> >>> /* Keep the following compatibles for device tree compatibility */
> >>> - { .compatible = "snps,spear-ahci", },
> >>> { .compatible = "ibm,476gtr-ahci", },
> >>> - { .compatible = "snps,dwc-ahci", },
> >>> { .compatible = "hisilicon,hisi-ahci", },
> >>> { .compatible = "cavium,octeon-7130-ahci", },
> >>> { /* sentinel */ }
> >>
> >>
> >> --
> >> Damien Le Moal
> >> Western Digital Research
> >
>
>
> --
> Damien Le Moal
> Western Digital Research