From: Chengming Zhou <zhouchengming@bytedance.com>
To: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, vschneid@redhat.com
Cc: linux-kernel@vger.kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: [PATCH v2 00/10] sched: task load tracking optimization and cleanup
Date: Wed, 13 Jul 2022 12:04:20 +0800 [thread overview]
Message-ID: <20220713040430.25778-1-zhouchengming@bytedance.com> (raw)
Hi all,
This patch series is optimization and cleanup for task load tracking
when task migrate CPU/cgroup or switched_from/to_fair().
There are three types of detach/attach_entity_load_avg (except fork and
exit case) for a fair task:
1. task migrate CPU (on_rq migrate or wake_up migrate)
2. task migrate cgroup (detach then attach)
3. task switched_from/to_fair (detach later attach)
patch1 optimize the on_rq migrate CPU case by combine detach into dequeue,
so we don't need to do detach_entity_cfs_rq() in migrate_task_rq_fair()
any more.
patch3-4 cleanup the migrate cgroup case by remove cpu_cgrp_subsys->fork(),
since we already do the same thing in sched_cgroup_fork().
patch1-4 have been reviewed earlier, but conflicts with the current tip
tree, so include them here as a patchset. Sorry for the inconvenience.
patch6-7 use update_load_avg() to do attach/detach after check sched_avg
last_update_time, is preparation patch for the following patches.
patch8-9 fix load tracking for new forked !fair task and when task
switched_from_fair().
After these changes, the task sched_avg last_update_time is reset to 0
when migrate from CPU/cgroup or switched_from_fair(), to save updated
sched_avg for next attach.
Thanks.
Changes in v2:
- split task se depth maintainence into a separate patch3, suggested
by Peter.
- reorder patch6-7 before patch8-9, since we need update_load_avg()
to do conditional attach/detach to avoid corner cases like twice
attach problem.
Chengming Zhou (10):
sched/fair: combine detach into dequeue when migrating task
sched/fair: update comments in enqueue/dequeue_entity()
sched/fair: maintain task se depth in set_task_rq()
sched/fair: remove redundant cpu_cgrp_subsys->fork()
sched/fair: reset sched_avg last_update_time before set_task_rq()
sched/fair: delete superfluous SKIP_AGE_LOAD
sched/fair: use update_load_avg() to attach/detach entity load_avg
sched/fair: fix load tracking for new forked !fair task
sched/fair: stop load tracking when task switched_from_fair()
sched/fair: delete superfluous set_task_rq_fair()
kernel/sched/core.c | 27 ++------
kernel/sched/fair.c | 144 ++++++++++------------------------------
kernel/sched/features.h | 1 -
kernel/sched/sched.h | 14 +---
4 files changed, 41 insertions(+), 145 deletions(-)
--
2.36.1
next reply other threads:[~2022-07-13 4:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 4:04 Chengming Zhou [this message]
2022-07-13 4:04 ` [PATCH v2 01/10] sched/fair: combine detach into dequeue when migrating task Chengming Zhou
2022-07-13 4:04 ` [PATCH v2 02/10] sched/fair: update comments in enqueue/dequeue_entity() Chengming Zhou
2022-07-13 4:04 ` [PATCH v2 03/10] sched/fair: maintain task se depth in set_task_rq() Chengming Zhou
2022-07-14 12:30 ` Dietmar Eggemann
2022-07-14 13:03 ` [External] " Chengming Zhou
2022-07-18 7:16 ` Vincent Guittot
2022-07-13 4:04 ` [PATCH v2 04/10] sched/fair: remove redundant cpu_cgrp_subsys->fork() Chengming Zhou
2022-07-14 12:31 ` Dietmar Eggemann
2022-07-14 13:06 ` [External] " Chengming Zhou
2022-07-13 4:04 ` [PATCH v2 05/10] sched/fair: reset sched_avg last_update_time before set_task_rq() Chengming Zhou
2022-07-14 12:31 ` Dietmar Eggemann
2022-07-19 8:49 ` Vincent Guittot
2022-07-13 4:04 ` [PATCH v2 06/10] sched/fair: delete superfluous SKIP_AGE_LOAD Chengming Zhou
2022-07-14 12:33 ` Dietmar Eggemann
2022-07-14 13:24 ` [External] " Chengming Zhou
2022-07-13 4:04 ` [PATCH v2 07/10] sched/fair: use update_load_avg() to attach/detach entity load_avg Chengming Zhou
2022-07-15 11:18 ` Dietmar Eggemann
2022-07-15 16:21 ` [External] " Chengming Zhou
2022-07-19 10:29 ` Vincent Guittot
2022-07-20 13:40 ` Chengming Zhou
2022-07-20 15:34 ` Vincent Guittot
2022-07-21 13:56 ` Chengming Zhou
2022-07-21 14:13 ` Vincent Guittot
2022-07-19 15:02 ` Dietmar Eggemann
2022-07-20 13:43 ` Chengming Zhou
2022-07-13 4:04 ` [PATCH v2 08/10] sched/fair: fix load tracking for new forked !fair task Chengming Zhou
2022-07-19 12:35 ` Vincent Guittot
2022-07-20 13:48 ` [External] " Chengming Zhou
2022-07-13 4:04 ` [PATCH v2 09/10] sched/fair: stop load tracking when task switched_from_fair() Chengming Zhou
2022-07-14 12:33 ` Dietmar Eggemann
2022-07-14 13:43 ` [External] " Chengming Zhou
2022-07-15 11:15 ` Dietmar Eggemann
2022-07-15 16:35 ` Chengming Zhou
2022-07-19 13:20 ` Vincent Guittot
2022-07-27 10:55 ` Chengming Zhou
2022-07-13 4:04 ` [PATCH v2 10/10] sched/fair: delete superfluous set_task_rq_fair() Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713040430.25778-1-zhouchengming@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox