public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Manyi Li <limanyi@uniontech.com>
To: bhelgaas@google.com, refactormyself@gmail.com, kw@linux.com,
	rajatja@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Manyi Li <limanyi@uniontech.com>
Subject: [PATCH] PCI/ASPM: Should not report ASPM support to BIOS if FADT indicates ASPM is unsupported
Date: Wed, 13 Jul 2022 19:26:12 +0800	[thread overview]
Message-ID: <20220713112612.6935-1-limanyi@uniontech.com> (raw)

Startup log of ASUSTeK X456UJ Notebook show:
[    0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it
[   48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[   48.092479] pcieport 0000:00:1c.5:   device [8086:9d15] error status/mask=00000001/00002000
[   48.092481] pcieport 0000:00:1c.5:    [ 0] RxErr
[   48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5
[   48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5
[   48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5

Signed-off-by: Manyi Li <limanyi@uniontech.com>
---
 drivers/pci/pcie/aspm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index a96b7424c9bc..b173d3c75ae7 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)
 	if (!aspm_force) {
 		aspm_policy = POLICY_DEFAULT;
 		aspm_disabled = 1;
+		aspm_support_enabled = false;
 	}
 }
 
-- 
2.20.1




             reply	other threads:[~2022-07-13 11:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 11:26 Manyi Li [this message]
2022-07-13 18:28 ` [PATCH] PCI/ASPM: Should not report ASPM support to BIOS if FADT indicates ASPM is unsupported Bjorn Helgaas
2022-07-14  3:20   ` Kai-Heng Feng
2022-07-14  4:56     ` Matthew Garrett
     [not found]     ` <7305201c-eaf2-cb36-80fe-15174d3e33c7@uniontech.com>
2022-07-15  8:29       ` Matthew Garrett
     [not found]         ` <c8498fc1-854f-efdc-bbc8-3de67dcf6430@uniontech.com>
2022-07-15  9:32           ` Matthew Garrett
     [not found]             ` <62d14039.1c69fb81.86d3c.71c2SMTPIN_ADDED_BROKEN@mx.google.com>
2022-07-15 12:32               ` Rafael J. Wysocki
2022-07-15 12:56                 ` Rafael J. Wysocki
2022-07-15 22:49             ` Bjorn Helgaas
     [not found]     ` <62d11a02.1c69fb81.ee60c.b0efSMTPIN_ADDED_BROKEN@mx.google.com>
2022-07-15 12:24       ` Rafael J. Wysocki
2022-07-15 14:07         ` Rafael J. Wysocki
2022-08-15  9:02           ` Manyi Li
2022-08-15 18:56 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713112612.6935-1-limanyi@uniontech.com \
    --to=limanyi@uniontech.com \
    --cc=bhelgaas@google.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rajatja@google.com \
    --cc=refactormyself@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox