public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Francis Laniel <flaniel@linux.microsoft.com>
To: bpf@vger.kernel.org
Cc: Francis Laniel <flaniel@linux.microsoft.com>,
	Quentin Monnet <quentin@isovalent.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 0/1] bpftool: Align dumped file headers with skeletons
Date: Wed, 13 Jul 2022 16:44:37 +0200	[thread overview]
Message-ID: <20220713144439.19738-1-flaniel@linux.microsoft.com> (raw)

Hi.


First, I hope you are fine and the same for your relatives.

In this patch, I aligned dumped C file headers with that of skeletons, so the
first lines of C dumped files are the following:
/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
#ifndef __VMLINUX_H__
#define __VMLINUX_H__

The goal is to warn users this file must not be edited as it was automatically
generated.
Indeed, skeletons also contain the same message.

This patch is clearly not a big change which impacts the future of bpftool but
I think it could be welcomed.
If you see any way to improve it or have any question, feel free to ask.

Change since:
 v1:
  * Drop command used to generate the file and use the same warning message
  as skeletons.
  * Add SPDX license.
 v2:
  * Drop RFC tag.
  * Add Quentin Monnet Reviewed-By tag.

Francis Laniel (1):
  bpftool: Align dumped file generated header with skeletons.

 tools/bpf/bpftool/btf.c | 2 ++
 1 file changed, 2 insertions(+)


Best regards and thank you in advance.
-- 
2.25.1


             reply	other threads:[~2022-07-13 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 14:44 Francis Laniel [this message]
2022-07-13 14:44 ` [PATCH v3 1/1] bpftool: Align dumped file generated header with skeletons Francis Laniel
2022-07-13 14:47   ` Alexei Starovoitov
2022-07-13 14:53     ` Francis Laniel
2022-07-13 16:03       ` sdf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713144439.19738-1-flaniel@linux.microsoft.com \
    --to=flaniel@linux.microsoft.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=quentin@isovalent.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox