From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>
Subject: [PATCH v1 3/4] dmaengine: hsu: Use GENMASK() consistently
Date: Wed, 13 Jul 2022 20:22:34 +0300 [thread overview]
Message-ID: <20220713172235.22611-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20220713172235.22611-1-andriy.shevchenko@linux.intel.com>
For the masks replace chain of BIT() macros by GENMASK().
While at it, explicitly include bits.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/hsu/hsu.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/hsu/hsu.h b/drivers/dma/hsu/hsu.h
index 9e5956345748..1c1195709c2f 100644
--- a/drivers/dma/hsu/hsu.h
+++ b/drivers/dma/hsu/hsu.h
@@ -10,6 +10,7 @@
#ifndef __DMA_HSU_H__
#define __DMA_HSU_H__
+#include <linux/bits.h>
#include <linux/spinlock.h>
#include <linux/dma/hsu.h>
@@ -36,11 +37,11 @@
/* Bits in HSU_CH_SR */
#define HSU_CH_SR_DESCTO(x) BIT(8 + (x))
-#define HSU_CH_SR_DESCTO_ANY (BIT(11) | BIT(10) | BIT(9) | BIT(8))
+#define HSU_CH_SR_DESCTO_ANY GENMASK(11, 8)
#define HSU_CH_SR_CHE BIT(15)
#define HSU_CH_SR_DESCE(x) BIT(16 + (x))
-#define HSU_CH_SR_DESCE_ANY (BIT(19) | BIT(18) | BIT(17) | BIT(16))
-#define HSU_CH_SR_CDESC_ANY (BIT(31) | BIT(30))
+#define HSU_CH_SR_DESCE_ANY GENMASK(19, 16)
+#define HSU_CH_SR_CDESC_ANY GENMASK(31, 30)
/* Bits in HSU_CH_CR */
#define HSU_CH_CR_CHA BIT(0)
--
2.35.1
next prev parent reply other threads:[~2022-07-13 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 17:22 [PATCH v1 1/4] dmaengine: hsu: Finish conversion to managed resources Andy Shevchenko
2022-07-13 17:22 ` [PATCH v1 2/4] dmaengine: hsu: using for_each_set_bit to simplify the code Andy Shevchenko
2022-07-13 17:22 ` Andy Shevchenko [this message]
2022-07-13 17:22 ` [PATCH v1 4/4] dmaengine: hsu: Include headers we are direct user of Andy Shevchenko
2022-08-23 15:07 ` [PATCH v1 1/4] dmaengine: hsu: Finish conversion to managed resources Andy Shevchenko
2022-09-04 17:19 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713172235.22611-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox